SSL

[seanmonstar]

[seanmonstar]

ssl support for the client exists, still lacking server support

[cactorium]

Is it alright if I take a stab at this?

[seanmonstar]

@cactorium I'd be delighted if this showed up as a PR :D

Some notes: I'd imagine adding a pub fn https(ip: IpAddr, port: Port, cert: Path, key: Path) or something similar. The paths to the cert and key can be Options on the Server. The HttpListener would probably need to become an enum similar to HttpStream, and the Https variant accepting those Paths.

[cactorium]

@seanmonstar Awesome :D

I think I did it? #199 I'm still working on figuring out how to test it, but here's something to look at for now

[veeti]

What's the story for certificate validation in the client?

[cactorium]

https://github.com/hyperium/hyper/blob/master/src/net.rs#L257 It looks like they're verified, peek around there and the openssl docs if you want more details: https://www.openssl.org/docs/ssl/SSL_CTX_set_verify.html

[seanmonstar]

@veeti see http://hyperium.github.io/hyper/hyper/client/struct.Client.html#method.set_ssl_verifier

[veeti]

Thanks: so (rust-)openssl does verification, but is something required on the hyper side? I see there's no default verifier included and the provided client example accepts everything for me. Is this expected? Should I file a bug for this?

[seanmonstar]

@veeti you can set a verifier function on Client. I guess a default could be similar to Python or nodejs.