Skip to content

Update to bitflags 2 #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update to bitflags 2 #134

wants to merge 1 commit into from

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Mar 20, 2023

Updates to bitflags version 2.

@seanmonstar
Copy link
Member

Hm, looks like bitflags decided to bump its MSRV, but I can't find any reason given as for what it was needed.

We don't really need bitflags, we could inline a simple struct Flags(u64) with contains and insert methods, and ditch this dependency.

@tottoto tottoto mentioned this pull request Mar 21, 2023
Merged
@tottoto
Copy link
Contributor Author

tottoto commented Mar 21, 2023

Thanks for your review! I published #135 following your comment.

@tottoto tottoto closed this Mar 21, 2023
@tottoto tottoto deleted the update-to-bitflags-2 branch March 22, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tottoto @seanmonstar