Skip to content

Commit a70c4c4

Browse files
committed
custom job_config
1 parent 06b6f24 commit a70c4c4

File tree

6 files changed

+16
-11
lines changed

6 files changed

+16
-11
lines changed

torchtitan/config/job_config.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -131,12 +131,6 @@ class Model:
131131
"""
132132

133133

134-
@dataclass
135-
class HFTransformers:
136-
model: str = ""
137-
"""HuggingFace model ID (e.g., 'Qwen/Qwen3-4B-Instruct-2507')"""
138-
139-
140134
@dataclass
141135
class Optimizer:
142136
name: str = "AdamW"
@@ -903,7 +897,6 @@ class JobConfig:
903897
profiling: Profiling = field(default_factory=Profiling)
904898
metrics: Metrics = field(default_factory=Metrics)
905899
model: Model = field(default_factory=Model)
906-
hf_transformers: HFTransformers = field(default_factory=HFTransformers)
907900
optimizer: Optimizer = field(default_factory=Optimizer)
908901
lr_scheduler: LRScheduler = field(default_factory=LRScheduler)
909902
training: Training = field(default_factory=Training)

torchtitan/experiments/transformers_backend/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ hf_assets_path = "./tests/assets/tokenizer"
1717
+model = "Qwen/Qwen3-4B-Instruct-2507"
1818
...
1919
```
20-
- Train: `LOG_RANK=7 CONFIG_FILE=<YOUR_PATHQ/torchtitan/experiments/transformers_backend/configs/qwen3_fsdp2_tp2_pp2.toml ./run_train.sh`
20+
- Train: `LOG_RANK=7 CONFIG_FILE=<YOUR_PATHQ/torchtitan/experiments/transformers_backend/configs/qwen3_fsdp2_tp2_pp2.toml ./run_train.sh --job.custom_config_module=torchtitan.experiments.transformers_backend.job_config --compile.enable`
21+
- Make sure you have created the tokenizers beforehand
2122
<img width="1334" height="453" alt="image" src="https://github.com/user-attachments/assets/da459448-027b-4af9-8176-6a3e433a272c" />
2223

2324
## Supported Features

torchtitan/experiments/transformers_backend/infra/parallelize_hf_transformers.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@
2424
RowwiseParallel,
2525
SequenceParallel,
2626
)
27-
from torchtitan.config import JobConfig, TORCH_DTYPE_MAP
27+
from torchtitan.experiments.transformers_backend.job_config import JobConfig
28+
from torchtitan.config import TORCH_DTYPE_MAP
2829
from torchtitan.config.job_config import ActivationCheckpoint as ACConfig
2930
from torchtitan.distributed import NoParallel, ParallelDims
3031

torchtitan/experiments/transformers_backend/infra/pipeline_hf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
)
2020

2121
from torchtitan.components.loss import LossFunction
22-
from torchtitan.config import JobConfig
22+
from torchtitan.experiments.transformers_backend.job_config import JobConfig
2323
from torchtitan.distributed import ParallelDims
2424
from torchtitan.distributed.pipeline_parallel import build_pipeline_schedule
2525
from torchtitan.protocols.train_spec import BaseModelArgs, ParallelizeFunction
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
from dataclasses import dataclass, field
2+
3+
@dataclass
4+
class HFTransformers:
5+
model: str = ""
6+
"""HuggingFace model ID (e.g., 'Qwen/Qwen3-4B-Instruct-2507')"""
7+
8+
@dataclass
9+
class JobConfig:
10+
hf_transformers: HFTransformers = field(default_factory=HFTransformers)

torchtitan/experiments/transformers_backend/model/args.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from dataclasses import dataclass
88

99
from torch import nn
10-
from torchtitan.config import JobConfig
10+
from torchtitan.experiments.transformers_backend.job_config import JobConfig
1111
from torchtitan.models.utils import get_dense_model_nparams_and_flops
1212
from torchtitan.protocols import BaseModelArgs
1313
from transformers import AutoConfig

0 commit comments

Comments
 (0)