-
Notifications
You must be signed in to change notification settings - Fork 407
Adds Snapdragon X Elite and X Plus GPU scores to hardware.ts #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider it a GPU still - in more long-term ideally, we'd be able to use the device info they put and customise snippets and even recommend models for their tasks down the line.
Besides, down the line when NPUs are more mainstream it might make sense to add it as a separate add-on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mrkiura - thanks a ton for your contribution, please do make sure to run the linter so that the lint test passes.
If you use VS code then you can do so with the prettier
extension too.
Thanks @coyotte508 @Vaibhavs10 I have updated the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe of interest to @mfuntowicz too
It seems like the Test/node and (Test/ browser) checks are failing because this URL in packages/hub/src/utils/WebBlob.spec.ts references a file from runwayml's account, but Runway is no longer maintaining a HuggingFace organization. It probably needs to be addressed in a different PR. |
yes you can ignore those tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to agree with @coyotte508, it somehow feels more natural to classify them as CPUs, but no strong opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge then, we can revisit the classification when we have a bit more candidates? ✅
Thanks a lot again for the contribution @mrkiura ❤️ |
Added:
Snapdragon X Elite
Snapdragon X Plus
Addresses: #764
Source: https://www.qualcomm.com/products/mobile/snapdragon/laptops-and-tablets/snapdragon-x-elite