Skip to content

Track download stats for the ACE-Step repo. #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DumoeDss
Copy link

No description provided.

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @DumoeDss - few nits and we should be golden, I'm not sure why the library is set to diffusers in the repo: https://huggingface.co/ACE-Step/ACE-Step-v1-3.5B when it actually uses the acestep model library: https://github.com/ace-step/ACE-Step/blob/74121a5d8a9af2fd651ba70869e78868442f6329/infer.py#L4

let's fix that too please! 🙏

@@ -1040,6 +1040,14 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
countDownloads: `path:"model_vae_fp16.pt"`,
snippets: snippets.threedtopia_xl,
},
acestep: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this keyword should be present in the model metadata too here: https://huggingface.co/ACE-Step/ACE-Step-v1-3.5B

you can do so by adding this tag in the model README.

repoName: "ACE-Step",
repoUrl: "https://github.com/ace-step/ACE-Step",
filter: false,
countDownloads: `path:"ace_step_transformer/diffusion_pytorch_model.safetensors"`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps easier would be that we track it via the config.json: https://huggingface.co/ACE-Step/ACE-Step-v1-3.5B/blob/main/config.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(tracking config.json is already the default behavior)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants