[do not merge] HunyuanDIT refactor #8290
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 23, 2024 16:30
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
commented
May 28, 2024
src/diffusers/models/attention.py
Outdated
|
|
||
| from typing import Tuple, Union, Optional | ||
|
|
||
| class HunyuanDiTAttentionPool(nn.Module): |
There was a problem hiding this comment.
moved to hunyuan_transformer_2d.py
yiyixuxu
commented
May 28, 2024
|
|
||
| A convolution based approach to patchifying a 2D image w/ embedding projection. | ||
| class AdaLayerNormShift(nn.Module): |
There was a problem hiding this comment.
This is refactored from default_modulation: can you tell us more about it? Is it part of the AdaLayerNorm family but without the scale? is there a reference? should we move to embeddings.py with other normalization methods?
yiyixuxu
commented
May 28, 2024
| self.extra_in_dim = 256 * 6 + hidden_size | ||
|
|
||
| # Text embedding for `add` | ||
| self.pos_embed = PatchEmbed( |
There was a problem hiding this comment.
I refactored this with our PatchEmbed but we are not actually adding the position embedding here - does it make sense to call it pos_embed still?
refactor rotary embedding + move dit block to dit model file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #8240
to-do:
HunyuanDiT2DModel: removedHunyuanDiTPatchEmbed,HunyuanDiTTimestepEmbedderapply_rotary_embHunyuanDiTBlock: keep it as a Hunyuan-specific block and move to the same file asHunyuanDiT2DModel