Fix from_ckpt for Stable Diffusion 2.x #3662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@williamberman could you check if this might already be fixed with #3657 ? |
|
unrelated! that PR was controlnet specific |
Comment on lines
-1429
to
+1439
| model_type == "FrozenOpenCLIPEmbedder" | ||
| model_type = "FrozenOpenCLIPEmbedder" | ||
| stable_unclip = "txt2img" | ||
| elif pipeline_name == "StableUnCLIPImg2ImgPipeline": | ||
| model_type == "FrozenOpenCLIPEmbedder" | ||
| model_type = "FrozenOpenCLIPEmbedder" | ||
| stable_unclip = "img2img" | ||
| elif pipeline_name == "PaintByExamplePipeline": | ||
| model_type == "PaintByExample" | ||
| model_type = "PaintByExample" | ||
| elif pipeline_name == "LDMTextToImagePipeline": | ||
| model_type == "LDMTextToImage" | ||
| model_type = "LDMTextToImage" |
There was a problem hiding this comment.
I'm not familiar with this part of the code but this looks good to me, the == seems to be a typo
|
The documentation is not available anymore as the PR was closed or merged. |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3661
This is because
from_ckptusesFrozenCLIPEmbedderforStableDiffusionPipelinebut it should beFrozenOpenCLIPEmbedderin Stable Diffusion 2.x.The original
download_from_original_stable_diffusion_ckptuses a layer that only presents in Stable Diffusion 2.x checkpoint to infer themodel_type, which is not work withfrom_ckptbecause it overrides the param. I think we can just leave themodel_typeempty for Stable Diffusion pipelines and then it will be inferred correctly.By the way, this PR also fixes some invalid assignments for
model_type.