Skip to content

[UNet3DModel] Fix with attn processor #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2023
Merged

[UNet3DModel] Fix with attn processor #2790

merged 2 commits into from
Mar 23, 2023

Conversation

patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Mar 23, 2023 •
edited
Loading

Adding this functionality also fixes:

FAILED tests/models/test_models_unet_3d_condition.py::UNet3DConditionModelTests::test_from_save_pretrained - AssertionError: 0.04317846894264221 not less than or equal to 5e-05 : Models give different forward passes
FAILED tests/models/test_models_unet_3d_condition.py::UNet3DConditionModelTests::test_from_save_pretrained_variant - AssertionError: 0.04441814497113228 not less than or equal to 5e-05 : Models give different forward passes

@patrickvonplaten patrickvonplaten changed the title [UNet3DModel] Fix attn processor [UNet3DModel] Fix with attn processor Mar 23, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 23, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@patrickvonplaten patrickvonplaten merged commit a8315ce into main Mar 23, 2023
@patrickvonplaten patrickvonplaten deleted the attn_proc_for_unet3d branch March 23, 2023 08:56
w4ffl35 pushed a commit to w4ffl35/diffusers that referenced this pull request Apr 14, 2023
@patrickvonplaten @w4ffl35
[UNet3DModel] Fix with attn processor (huggingface#2790)
c2b5ec3 
* [UNet3DModel] Fix attn processor

* make style
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@patrickvonplaten
[UNet3DModel] Fix with attn processor (huggingface#2790)
ddb1788 
* [UNet3DModel] Fix attn processor

* make style
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@patrickvonplaten
[UNet3DModel] Fix with attn processor (huggingface#2790)
5ad9a73 
* [UNet3DModel] Fix attn processor

* make style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickvonplaten @HuggingFaceDocBuilderDev