-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Support for Offset Noise in examples #2753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The documentation is not available anymore as the PR was closed or merged. |
@@ -297,6 +297,7 @@ def parse_args(): | |||
parser.add_argument( | |||
"--enable_xformers_memory_efficient_attention", action="store_true", help="Whether or not to use xformers." | |||
) | |||
parser.add_argument("--noise_offset", type=float, default=0, help="The scale of noise offset.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parser.add_argument("--noise_offset", type=float, default=0, help="The scale of noise offset.") | |
parser.add_argument("--noise_offset", type=float, default=0, help="The scale of noise offset. See: https://www.crosslabs.org//blog/diffusion-with-offset-noise for more information.") |
@@ -333,6 +333,7 @@ def parse_args(): | |||
parser.add_argument( | |||
"--enable_xformers_memory_efficient_attention", action="store_true", help="Whether or not to use xformers." | |||
) | |||
parser.add_argument("--noise_offset", type=float, default=0, help="The scale of noise offset.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parser.add_argument("--noise_offset", type=float, default=0, help="The scale of noise offset.") | |
parser.add_argument("--noise_offset", type=float, default=0, help="The scale of noise offset. See: https://www.crosslabs.org//blog/diffusion-with-offset-noise for more information.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, looks good to me - @williamberman @sayakpaul can you also take a quick look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb!
Just curious -- have you performed any experiments with noise offsets?
I have used this in my personal project to achieve better dark lighting. @sayakpaul |
Ah interesting! I think once the code quality checks pass, we can merge this. |
Done. @sayakpaul |
Excellent! Well done 🔥 |
* add noise offset * make style
* add noise offset * make style
As title.
Offset noise is a recent training trick introduced by crosslabs.