Marigold Update: v1-1 models, Intrinsic Image Decomposition pipeline, documentation #10884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix missing prediction_type in register_to_config in the normals pipeline
update comments about num_inference_steps and ensemble_size minor fixes in comments of marigold normals and depth pipelines
2 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Looks like most failures come from the |
|
@toshas Thanks for the PR & congrats on the release! The failing tests are unrelated and have been failing across all PRs. I'll try to review the full changes soon! |
stevhliu
approved these changes
Feb 24, 2025
yiyixuxu
approved these changes
Feb 24, 2025
src/diffusers/pipelines/marigold/pipeline_marigold_intrinsics.py
Outdated
Show resolved
Hide resolved
a-r-r-o-w
approved these changes
Feb 24, 2025
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
compute n_targets on the go add a consistency check for vae_scale_factor
move quantitative evaluation and predictive uncertainty sections of marigold into the end
|
I finished the improvements; please let me know if there is anything else. Thanks! |
|
thanks a lot! @toshas |
|
Hello @toshas When are you planning to release the new models |
|
The models have been released! @nitinmukesh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates and refactors the Marigold pipelines to support the new
v1-1models, enabling fast inference (1-4 steps) with DDIM. It also introduces a new Intrinsic Image Decomposition (IID) pipeline.Fixes #10883
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul @yiyixuxu