-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[LoRA] Add LoRA support to AuraFlow #10216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
da41f32
to
c8364bc
Compare
Thanks for the helping hand, @hlky! |
See https://github.com/huggingface/diffusers/blob/main/tests/lora/test_lora_layers_flux.py https://github.com/huggingface/diffusers/blob/main/tests/lora/test_lora_layers_mochi.py etc as an example for tests. Seems to be missing |
20b5f2d
to
80ac0d4
Compare
@sayakpaul Okay; I'm at a point where I've got actual, valid test failures but have no idea where to look. |
912fb8d
to
f5b9f90
Compare
Here's the log after the latest commit: pytest.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have left some comments to fix a couple of things. LMK if they're unclear.
f5b9f90
to
1c79095
Compare
Latest test log. |
24812f3
to
d2ecef4
Compare
d2ecef4
to
a20d03d
Compare
@sayakpaul Last CI ping. 😅 |
Code styling issues need to be fixed. |
@bot /style |
Style fixes have been applied. View the workflow run here. |
@sayakpaul CI blocked again. 🥹 |
@sayakpaul CI needs approval. 😅 |
@sayakpaul CI ping. 🥹 |
@sayakpaul Since I'm a first-time contributor, you'll need to approve the workflows on GitHub, opening/closing the PR or pushing commits doesn't seem to work. GitHub shows me the following notice on desktop, but the corresponding notice is invisible on mobile: |
@sayakpaul Another approval on CI please. |
@sayakpaul Merge before other issues pop up? 😛 |
@sayakpaul can we please get this merged? very excited about getting AF ecosystem up to speed. |
@sayakpaul The CI failures seem unrelated:
EDIT: This seems to be the cause:
|
Thanks for your contributions. |
Thanks so much for the reviews and patience! |
What does this PR do?
This PR is a simple rebase of #9017
cc @sayakpaul for review.
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.