Move timeout from the incoming socket to the outgoing one.

[mdirolf]

The issue was that when setting a timeout it was only getting set on the incoming socket, not on the outgoing http request. So the incoming request would get closed but the error handler wouldn't run, and the outgoing request would remain open.

This PR moves the timeout from the incoming socket to the outgoing one, and aborts the request on a timeout. The result is that error callbacks will run on a timeout, and that outgoing http requests won't remain open.

[josegonzalez]

Wouldn't you want both a request and a response timeout instead?

[mdirolf]

What is the use case for having a separate timeout on the incoming socket? With the above commit if the outgoing request times out the request aborts and the proxy server responds immediately.

[josegonzalez]

First, this would be a backwards incompatible change. Second, you could have a client that opens a connection but doesnt actually send a request to the node proxy, which is what I think the original feature covers.

[mdirolf]

Fair enough - I'll change the PR to just add a new option to set a timeout for the outgoing http request.

[jcrugzz]

@mdirolf I like this, could you just change the proxy_timeout to proxyTimeout. My OCD wants camelCase ;). Otherwise LGTM

[Rush]

Okay seems like my pull request #658 seems to achieve the same thing. I have timeout and targetTimeout there, if this pull request is gonna be pulled please take the test for original timeout as well.

[Rush]

Additionally the test for socket.io needs to be fixed, for which my pull request also has a change.

[jcrugzz]

@RushPL yes i still wanted to steal your tests :). It all comes down to the naming so I will pull whatever PR that uses a proxyTimeout naming as they do accomplish the same thing.

[jcrugzz]

fixed with #658