Skip to content

lxml doesn't roundtrip comments after </html> #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gsnedders opened this issue May 6, 2020 · 0 comments · Fixed by #496
Closed

lxml doesn't roundtrip comments after </html> #488

gsnedders opened this issue May 6, 2020 · 0 comments · Fixed by #496
Labels
bug parser serializer

Comments

@gsnedders
Copy link
Member 

>>> from html5lib import parse, serialize
>>> start = "</html><!-- a --><!-- b -->"
>>> print(serialize(parse(start, treebuilder="lxml"), tree="lxml"))
</html><!-- b --><!-- a -->
gsnedders added a commit to gsnedders/html5lib-python that referenced this issue May 22, 2020
@gsnedders
Fix html5lib#488: append document-child comments in document order in…
fb68f8c 
… lxml
@gsnedders gsnedders mentioned this issue May 22, 2020
Merged
gsnedders added a commit to html5lib/html5lib-tests that referenced this issue May 26, 2020
@gsnedders
Add a test for order of comments after </html>
bdc18c4 
Notably, html5lib-python's lxml treebuilder gets this wrong:
html5lib/html5lib-python#488
@gsnedders gsnedders mentioned this issue May 26, 2020
Merged
sideshowbarker pushed a commit to html5lib/html5lib-tests that referenced this issue May 28, 2020
@gsnedders @sideshowbarker
Add a test for order of comments after </html>
71eebd5 
Notably, html5lib-python's lxml treebuilder gets this wrong:
html5lib/html5lib-python#488
gsnedders added a commit to gsnedders/html5lib-python that referenced this issue Jun 9, 2020
@gsnedders
Fix html5lib#488: append document-child comments in document order in…
0bffd60 
… lxml
gsnedders added a commit that referenced this issue Jun 9, 2020
@gsnedders
Fix #488: append document-child comments in document order in lxml
5c1a695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug parser serializer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #488: append document-child comments in document order in lxml gsnedders/html5lib-python
1 participant
@gsnedders