Add Travis-CI support #546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the tidy-html5-tests repository as a submodule and makes Travis-CI run the full suite of tests on every commit and PR.
lhchavez
commented
May 6, 2017
.gitmodules
Outdated
| @@ -0,0 +1,3 @@ | |||
| [submodule "tests"] | |||
| path = tests | |||
| url = https://github.com/lhchavez/tidy-html5-tests.git | |||
There was a problem hiding this comment.
Note that this needs to be changed to https://github.com/htacg/tidy-html5-tests , but since I needed to test this out with my own repository I had to hardcode my own fork here.
If we ever decide to go forward, I'll change this with the correct URL.
|
PTAL! This is how it would look like: https://travis-ci.org/lhchavez/tidy-html5/builds/229552310 . Every pull request would also display a small green / red badge with the result of the tests, for immediate feedback to any PR author. Note that this requires htacg/tidy-html5-tests#18 in order to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the tidy-html5-tests repository as a submodule and
makes Travis-CI run the full suite of tests on every commit and PR.
This change is intended to fix #545,
but since this checks out the test repository as a submodule, there are two
downsides:
as broken, or not receive automated coverage (in the case new tests are
to be added).
This change also only runs the
testbaseset, because I could not find how torun the others correctly.