-
Notifications
You must be signed in to change notification settings - Fork 429
--vertical-space yes adds too much after comment #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jidanni thank you for the comment, but do not yet understand what is the request, or bug. or what???... Seems you have subsequently changed that <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>Is. #811</title>
</head>
<body>
<ol>
<li>
<p>para 1,
<!-- comm 1 -->
<!-- comm 2 -->
<!-- comm 3 -->
cont with <a href="#">link 1</a> more...
</p>
<p>para 2,
<!-- comm 4 -->
cont with <a href="#2">link 2</a> more... </p>
</li>
</ol>
</body>
</html> Running current tidy, with <!DOCTYPE html>
<html lang="en">
<head>
<meta name="generator" content=
"HTML Tidy for HTML5 for Windows version 5.7.22">
<meta charset="utf-8">
<title>Is. #811</title>
</head>
<body>
<ol>
<li>
<p>para 1, <!-- comm 1 -->
<!-- comm 2 -->
<!-- comm 3 -->
cont with <a href="#">link 1</a> more...</p>
<p>para 2, <!-- comm 4 -->
cont with <a href="#2">link 2</a> more...</p>
</li>
</ol>
</body>
</html> Seems the output is nicely relined, evenly indented, looks Where, or what, is the problem? Please provide small sample input, config used, tidy version, current output, output expected, use case for changes, etc, etc, ... The output of comments may benefit from ideas, specs, refs, like in #808, but what are the specific repeatable cases? Give small samples... Just implying Need further feedback to understand... thanks... |
You are totally right. I had my own personal filter interfering. But wait, I still found a last problem,
Yes, we want vertical space, but not this extra blank line.... |
@jidanni, wow, you sort of close one issue - with Then rename the issue... and jump on the But this is also very difficult, or at least confusing, ... to understand... and would have preferred closing this, and opening a new issue... if need be... but, ok.... The quite terse QuickRef says I do not profess to know all that There is no doubt it is a sort of big compromise... a choice... It was interesting to add this option, for fun!, when running the 240 case-1003361
</div>
+
<div lang="sp">
case-1004512
- <li><span class="c1">y2</span></li>
+ <li><span class="c1">y2</span>
+ </li>
case-1014993
- <td></td>
+ <td>
+ </td>
case-1050673
- <title></title>
+ <title>
+ </title>
case-1067112
<div class="Section1">
<p>Word 2000</p>
+
<p> </p>
+
<h1>Heading 1</h1>
- <h2><strong>Heading 2</strong></h2>
- <h3><strong>Heading 3</strong></h3>
+
+ <h2><strong>Heading 2</strong>
+ </h2>
+
+ <h3><strong>Heading 3</strong>
+ </h3>
+
<p> </p>
+
<p>Some ordinary text to see how it handles paragraphs</p>
+
<p>A second paragraph</p>
+
<p> </p>
+
<ul type="disc">
<li>One dot point</li>
+
<li>Two dot points</li>
+
<li>Three dot points</li>
</ul>
+
<p> </p>
+
case-836462c
<ol>
<!-- comment -->
- <li class="c1"><br /></li>
+
+ <li class="c1"><br />
+ </li>
</ol>
case-427810
<!-- use "-clean" or not to test both cases -->
- <p>Test inline element</p><blink>Proprietary inline element
- (blink)</blink> <wbr>Proprietary inline element (wbr) - note
- starts on new line, doesn't need end tag
+
+ <p>Test inline element</p>
+ <blink>Proprietary inline element (blink)</blink>
+ <wbr>Proprietary inline element (wbr) - note starts on new line,
+ doesn't need end tag
and onwards, for 100s of cases... While this is not an exhaustive demonstration of the option Maybe this information, and more, could/should form some But at this moment the outputs from Such fine grained control of At the moment this looks like Look forward to further feedback, comments, patch, PR, etc... but no more |
OK. On the man page "This option specifies if Tidy should add some extra
empty lines for readability." is just too loosely worded. Maybe it could
say "... one before comments, two before paragraphs..." or whatever it
actually does, at least not just "some". Thanks.
|
@jidanni thanks for the feedback, but ok, you have really effectively changed the title yet again... Now it is something like I spent quite a number of extra hours on trying to commence a sort of list... but was never happy... this classic-01.html is my results... at least a dozen cases... with examples... It does involve a lot of cases, sometimes not so easy to describe... maybe more than the above... If someone want to take this on, then they should open a new issue... and I hope they are willing to work on it, not just propose it... I will help... if there is positive feedback... But since it seems a |
See this nice bunch of comments?:
Let's "tidy" them even more,
See al;so #808.
The text was updated successfully, but these errors were encountered: