Skip to content

fix: move @sentry/sveltekit to production dependencies #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

thenbe
Copy link

@thenbe thenbe commented Apr 19, 2023

No description provided.

@hrueger
Copy link
Owner

hrueger commented Apr 19, 2023

Hi, thanks for the PR. I basically tried the same thing earlier, don't know why it was not working there.

@thenbe
Copy link
Author

thenbe commented Apr 19, 2023

Hi, thanks for the PR. I basically tried the same thing earlier, don't know why it was not working there.

You know, the same thing happened me. I believe it's due to the fact that your build script does not do a proper clean up before building, and that some artifacts from the the previous trial(s) are being leftover.

- "build": "vite build"
+ "build": "rm -rf ./{.svelte-kit,build} && svelte-kit sync && vite build"

@thenbe
Copy link
Author

thenbe commented Apr 19, 2023

@hrueger One final thing, you might want to look into pnpm (the pnpm deploy command in particular) if you're going to rely on this pattern. It's much faster for exactly this sort of stuff.

@hrueger
Copy link
Owner

hrueger commented Apr 19, 2023

Cool, I did not know about this. Thanks for the hint!

@thenbe thenbe closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants