-
Notifications
You must be signed in to change notification settings - Fork 2
π Beta #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0badbb3.
This reverts commit 3ab9ff6.
See: https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md#deprecations See: jestjs/jest#12089 BREAKING CHANGE: `api/test` no longer exports `mocked()`, it's available at `jest.mocked()` now
BREAKING CHANGE: default exports are no longer allowed when using **@hover/javascript/eslint/strict**
BREAKING CHANGE: upgrades Jest a major version (27 to 28)
BREAKING CHANGE: using new major version of Semantic Release in `ci-after-success`
BREAKING CHANGE: upgrades Jest a major version (28 to 29) BREAKING CHANGE: Node 12 is no longer supported
Merged
BREAKING CHANGE: **@swc/jest** is now the default Jest transform and **ts-jest** is no longer installed by default. To preserve the old transform behavior, install **ts-jest** as a \`devDependency\` in you project. β BREAKING CHANGE: the \`@hover/javascript/api/test\` API has been removed as **ts-jest** is no longer installed by default. If you're still using **ts-jest**, import its helpers directly from **ts-jest** instead of the \`/api/test\` entrypoint.
Jest no longer bundles it as of 28.x... which makes sense as installing JSDOM when we're using the default `testEnvironment` (`node`) is pretty silly. For now I'm opting to continue bundling it for the sake of simplicity, but we should probably consider modularizing @hover/javascript in the future.
BREAKING CHANGE: `ls.dirs()` from `api/commit` now takes an options object as the second parameter instead of a `prefix`. If you're using a prefix you'll need to make the following change: ```ts // Before ls.dirs('./packages', 'my-prefix'); // After ls.dirs('./packages', { prefix: 'my-prefix' }); ``` BREAKING CHANGE: `ls.dirs()` now excludes `node_modules` directories by default. If for some reason you want to include \`node_modules\`, you'll need to explicitly set \`exclude\` to \`null\`: ```ts // Before ls.dirs('./packages'); // After ls.dirs('./packages', { exclude: null }); ```
β¦f extending For consistency, up until now, the shared TypeScript configuration has lived in `src/config` with all of the other shared configurations that this package provides. For all of the other configurations we're able to simple re-export the configuration at the project root to provide it to consumers at `require('@hover/javascript/[config]')`. Because the TypeScript configuration is JSON, however, we were using `extends` instead of re-exporting. This has been causing all kinds of trouble within this package since we were extending from the `dist` directory. This finally moves the canonical TypeScript configuration to the root, so that we don't need to `extends` from `dist/` while preserving `src/config/tsconfig.json` via `extends` just in case. The actual configuration for this project itself still lives at `src/tsconfig.json`, but this prevents issues when anything (like the `ts-node` that gets loaded in `commitlint` from trying to read a non-existent `dist/tsconfig.json` if it does read the `tsconfig.json` at the root of the project.
BREAKING CHANGE: potential breaking change as some upgrades were major
See #860 |
Nevermind... semantic-release was not into that. |
# Conflicts: # package.json # yarn.lock
π This PR is included in version 7.0.0-next.3 π The release is available on: Your semantic-release bot π¦π |
π This PR is included in version 7.0.0 π The release is available on: Your semantic-release bot π¦π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Upgrade Jest to 28Upgrade Jest to 27.4dependencies
topeerDependencies
(optional) requiring β₯ 29.0API
Forward ts-jest utils fromRemovets-jest
, removemocked
api/test
since we're switching to SWC by default for JestConfiguration Changes
Set ts-jest transform unconditionallynevermind, we're switching to SWCTodo
skipLibCheck
... ts-jest and jest aren't playing nicely (can we get rid of this?yes)