(feat) propose new release v5.0.0 - Pure esm #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 11, 2025 13:37
Because the Angular way is to use outputs, via `chartInstance`
Because it will always be available on https://github.com/highcharts/highcharts-angular/blob/v4.0.1/README.md
This restores the demo page where the last chart was not drawn
Using most recommended rules
|
@karolkolodziej, you expressed interest in the previous PR. Could you take a look at the latest commits of this one (or just the entire thing), and let us know if something should be changed before merging ? @medbenmakhlouf, FYI, this is the continuation of your work, I hope it can get merged so we can all benefits from the many improvements you suggested. |
|
@karolkolodziej, I forgot to mention that you should enable GitHub Actions in the repository to benefit from CI |
4 tasks
ddragula
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Thank you, @PowerKiKi & @medbenmakhlouf, great work! Let's wait for the final review from @karolkolodziej and I think we can proceed with the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest version of #392, which were already bringing:
And now it also brings:
In my opinion, this is ready to be fully reviewed and merged. And possibly released, unless other breaking changes would be introduced at the same time.