use instanceof instead of isInstance() on the hot path

surely NBD, but such an easy thing to fix and remove all doubt

Author: gavinking

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BlobJavaTypeDescriptor.java

@@ -110,7 +110,7 @@ public <X> X unwrap(Blob value, Class<X> type, WrapperOptions options) {
 
 		try {
 			if ( BinaryStream.class.isAssignableFrom( type ) ) {
-				if ( BlobImplementer.class.isInstance( value ) ) {
+				if (value instanceof BlobImplementer) {
 					// if the incoming Blob is a wrapper, just pass along its BinaryStream
 					return (X) ( (BlobImplementer) value ).getUnderlyingStream();
 				}
@@ -120,7 +120,7 @@ public <X> X unwrap(Blob value, Class<X> type, WrapperOptions options) {
 				}
 			}
 			else if ( byte[].class.isAssignableFrom( type )) {
-				if ( BlobImplementer.class.isInstance( value ) ) {
+				if (value instanceof BlobImplementer) {
 					// if the incoming Blob is a wrapper, just grab the bytes from its BinaryStream
 					return (X) ( (BlobImplementer) value ).getUnderlyingStream().getBytes();
 				}
@@ -130,7 +130,7 @@ else if ( byte[].class.isAssignableFrom( type )) {
 				}
 			}
 			else if (Blob.class.isAssignableFrom( type )) {
-				final Blob blob =  WrappedBlob.class.isInstance( value )
+				final Blob blob =  value instanceof WrappedBlob
 						? ( (WrappedBlob) value ).getWrappedBlob()
 						: value;
 				return (X) blob;

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/BooleanJavaTypeDescriptor.java

@@ -85,18 +85,18 @@ public <X> Boolean wrap(X value, WrapperOptions options) {
 		if ( value == null ) {
 			return null;
 		}
-		if ( Boolean.class.isInstance( value ) ) {
+		if (value instanceof Boolean) {
 			return (Boolean) value;
 		}
-		if ( Number.class.isInstance( value ) ) {
+		if (value instanceof Number) {
 			final int intValue = ( (Number) value ).intValue();
 			return intValue != 0;
 		}
-		if ( Character.class.isInstance( value ) ) {
+		if (value instanceof Character) {
 			return isTrue( (Character) value );
 		}
-		if ( String.class.isInstance( value ) ) {
-			return isTrue((String) value);
+		if (value instanceof String) {
+			return isTrue( (String) value );
 		}
 		throw unknownWrap( value.getClass() );
 	}

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ByteArrayJavaTypeDescriptor.java

@@ -100,16 +100,16 @@ public <X> Byte[] wrap(X value, WrapperOptions options) {
 		if ( value == null ) {
 			return null;
 		}
-		if ( Byte[].class.isInstance( value ) ) {
+		if (value instanceof Byte[]) {
 			return (Byte[]) value;
 		}
-		if ( byte[].class.isInstance( value ) ) {
+		if (value instanceof byte[]) {
 			return wrapBytes( (byte[]) value );
 		}
-		if ( InputStream.class.isInstance( value ) ) {
+		if (value instanceof InputStream) {
 			return wrapBytes( DataHelper.extractBytes( (InputStream) value ) );
 		}
-		if ( Blob.class.isInstance( value ) || DataHelper.isNClob( value.getClass() ) ) {
+		if ( value instanceof Blob || DataHelper.isNClob( value.getClass() ) ) {
 			try {
 				return wrapBytes( DataHelper.extractBytes( ( (Blob) value ).getBinaryStream() ) );
 			}

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarDateJavaTypeDescriptor.java

@@ -120,11 +120,11 @@ public <X> Calendar wrap(X value, WrapperOptions options) {
 		if ( value == null ) {
 			return null;
 		}
-		if ( Calendar.class.isInstance( value ) ) {
+		if (value instanceof Calendar) {
 			return (Calendar) value;
 		}
 
-		if ( ! Date.class.isInstance( value ) ) {
+		if ( !(value instanceof Date)) {
 			throw unknownWrap( value.getClass() );
 		}
 

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarJavaTypeDescriptor.java

@@ -136,11 +136,11 @@ public <X> Calendar wrap(X value, WrapperOptions options) {
 		if ( value == null ) {
 			return null;
 		}
-		if ( Calendar.class.isInstance( value ) ) {
+		if (value instanceof Calendar) {
 			return (Calendar) value;
 		}
 
-		if ( ! java.util.Date.class.isInstance( value ) ) {
+		if ( !(value instanceof java.util.Date)) {
 			throw unknownWrap( value.getClass() );
 		}
 

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CalendarTimeJavaTypeDescriptor.java

@@ -120,11 +120,11 @@ public <X> Calendar wrap(X value, WrapperOptions options) {
 		if ( value == null ) {
 			return null;
 		}
-		if ( Calendar.class.isInstance( value ) ) {
+		if (value instanceof Calendar) {
 			return (Calendar) value;
 		}
 
-		if ( ! Date.class.isInstance( value ) ) {
+		if ( !(value instanceof Date)) {
 			throw unknownWrap( value.getClass() );
 		}
 

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CharacterArrayJavaTypeDescriptor.java

@@ -81,16 +81,16 @@ public <X> Character[] wrap(X value, WrapperOptions options) {
 		if ( value == null ) {
 			return null;
 		}
-		if ( Character[].class.isInstance( value ) ) {
+		if (value instanceof Character[]) {
 			return (Character[]) value;
 		}
-		if ( String.class.isInstance( value ) ) {
+		if (value instanceof String) {
 			return wrapChars( ( (String) value ).toCharArray() );
 		}
-		if ( Clob.class.isInstance( value ) ) {
+		if (value instanceof Clob) {
 			return wrapChars( DataHelper.extractString( ( (Clob) value ) ).toCharArray() );
 		}
-		if ( Reader.class.isInstance( value ) ) {
+		if (value instanceof Reader) {
 			return wrapChars( DataHelper.extractString( (Reader) value ).toCharArray() );
 		}
 		throw unknownWrap( value.getClass() );

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/CharacterJavaTypeDescriptor.java

@@ -59,14 +59,14 @@ public <X> Character wrap(X value, WrapperOptions options) {
 		if ( value == null ) {
 			return null;
 		}
-		if ( Character.class.isInstance( value ) ) {
+		if (value instanceof Character) {
 			return (Character) value;
 		}
-		if ( String.class.isInstance( value ) ) {
+		if (value instanceof String) {
 			final String str = (String) value;
 			return str.charAt( 0 );
 		}
-		if ( Number.class.isInstance( value ) ) {
+		if (value instanceof Number) {
 			final Number nbr = (Number) value;
 			return (char) nbr.shortValue();
 		}

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ClassJavaTypeDescriptor.java

@@ -56,10 +56,10 @@ public <X> Class wrap(X value, WrapperOptions options) {
 		if ( value == null ) {
 			return null;
 		}
-		if ( Class.class.isInstance( value ) ) {
+		if (value instanceof Class) {
 			return (Class) value;
 		}
-		if ( CharSequence.class.isInstance( value ) ) {
+		if (value instanceof CharSequence) {
 			return fromString( (CharSequence) value );
 		}
 		throw unknownWrap( value.getClass() );

hibernate-core/src/main/java/org/hibernate/type/descriptor/java/ClobJavaTypeDescriptor.java

@@ -97,7 +97,7 @@ public <X> X unwrap(final Clob value, Class<X> type, WrapperOptions options) {
 				}
 			}
 			else if ( String.class.isAssignableFrom( type ) ) {
-				if ( ClobImplementer.class.isInstance( value ) ) {
+				if (value instanceof ClobImplementer) {
 					// if the incoming Clob is a wrapper, just grab the bytes from its BinaryStream
 					return (X) ( (ClobImplementer) value ).getUnderlyingStream().asString();
 				}