Yo saucedo module command test (#3056)

* Create GenerateCommanTest in Generate folder

* Add ModuleGenerator to the builder

* Add the necessary mocks that ModuleCommand need

Author: jmolivas

Test/Builders/a.php

@@ -7,6 +7,9 @@
 use Drupal\Console\Utils\StringConverter;
 use Drupal\Core\Render\ElementInfoManager;
 use Drupal\Core\Routing\RouteProvider;
+use Drupal\Console\Utils\DrupalApi;
+use Drupal\Console\Utils\Site;
+use GuzzleHttp\Client;
 use Prophecy\Prophet;
 
 use Drupal\Console\Generator\AuthenticationProviderGenerator;
@@ -29,6 +32,29 @@ public static function extensionManager()
         return self::prophet()->prophesize(Manager::class)->reveal();
     }
 
+    /**
+     * @return \Prophecy\Prophecy\ObjectProphecy
+     */
+    public static function guzzleHttpClient()
+    {
+        return self::prophet()->prophesize(Client::class);
+    }
+
+    /**
+     * @return \Prophecy\Prophecy\ObjectProphecy
+     */
+    public static function drupalApi()
+    {
+        return self::prophet()->prophesize(DrupalApi::class);
+    }
+    /**
+     * @return \Prophecy\Prophecy\ObjectProphecy
+     */
+    public static function siteDrupal()
+    {
+        return self::prophet()->prophesize(Site::class);
+    }
+
     /**
      * @return \Prophecy\Prophecy\ObjectProphecy
      */
@@ -55,6 +81,15 @@ public static function permissionGenerator()
     }
 
 
+    /**
+     * @return \Prophecy\Prophecy\ObjectProphecy
+     */
+    public static function moduleGenerator()
+    {
+        return self::prophet()->prophesize(ModuleGenerator::class);
+    }
+
+
     /**
      * @return \Prophecy\Prophecy\ObjectProphecy
      */

Test/Command/Generate/GenerateCommandTest.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace Drupal\Console\Test\Command\Generate;
+
+use Symfony\Component\DependencyInjection\Container;
+use Drupal\Console\Test\BaseTestCase;
+
+abstract class GenerateCommandTest extends BaseTestCase
+{
+    /**
+     * @return \Symfony\Component\DependencyInjection\ContainerInterface Drupal container
+     */
+    protected function getContainer()
+    {
+        $container = new Container();
+        $container->set('twig', new \Twig_Environment());
+        return $container;
+    }
+}

Test/Command/Generate/ModuleCommandTest.php

@@ -7,8 +7,12 @@
 namespace Drupal\Console\Test\Command\Generate;
 
 use Drupal\Console\Command\Generate\ModuleCommand;
+use Drupal\Console\Test\Builders\a as an;
+use Drupal\Console\Utils\StringConverter;
+use Drupal\Console\Utils\Validator;
 use Symfony\Component\Console\Tester\CommandTester;
 use Drupal\Console\Test\DataProvider\ModuleDataProviderTrait;
+use GuzzleHttp;
 
 class ModuleCommandTest extends GenerateCommandTest
 {
@@ -40,9 +44,17 @@ public function testGenerateModule(
         $composer,
         $dependencies
     ) {
-        $command = new ModuleCommand($this->getHelperSet());
-        $command->setHelperSet($this->getHelperSet());
-        $command->setGenerator($this->getGenerator());
+        $generator = an::moduleGenerator();
+        $manager = an::extensionManager();
+        $command = new ModuleCommand(
+              $generator->reveal(),
+              new Validator($manager),
+              '/tmp',
+              new StringConverter(),
+              an::drupalApi()->reveal(),
+              an::guzzleHttpClient()->reveal(),
+              an::siteDrupal()->reveal()
+          );
 
         $commandTester = new CommandTester($command);
 
@@ -60,16 +72,8 @@ public function testGenerateModule(
             ],
             ['interactive' => false]
         );
-
+        $generator
+            ->generate($module, $machine_name, $module_path, $description, $core, $package, $featuresBundle, $composer, $dependencies);
         $this->assertEquals(0, $code);
     }
-
-    private function getGenerator()
-    {
-        return $this
-            ->getMockBuilder('Drupal\Console\Generator\ModuleGenerator')
-            ->disableOriginalConstructor()
-            ->setMethods(['generate'])
-            ->getMock();
-    }
 }