Add firmware upgrades #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chreekat
requested changes
May 23, 2025
There was a problem hiding this comment.
Thanks for this. Would you be willing to change things a bit in order to also improve the overall health of the repo?
- Add the contents of nix-hygiene.nix into system-common.nix, and delete nix-hygiene.nix
- Rename system-common.nix to shared/system-common.nix
- Export nixosModules.system-common instead of nixosModules.nix-hygiene
- Remove the FIXME on flake.nix line 30 while you're doing 3 :)
Comment on lines
+47
to
+48
| services.fwupd.enable = true; | ||
|
|
There was a problem hiding this comment.
This file imports system-common! :) So I don't think we need to enable it here.
| @@ -89,6 +89,8 @@ | |||
| # Enable the OpenSSH daemon. | |||
| # services.openssh.enable = true; | |||
|
|
|||
| services.fwupd.enable = true; | |||
|
|
|||
There was a problem hiding this comment.
Actually, I believe this file is unused and can just be deleted. In fact, stackage-builder/nixos-modules is good, but everything else under stackage-builder is unused after the migration to opencape!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21