Prepare release #386
Merged
Prepare release #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the changed `lsp-types` dep. Major bump since it re-exports a lot of lsp-types.
jneira
reviewed
Dec 28, 2021
| * Reduced dependency footprint (#383, #384) (@Bodigrim) | ||
| * Use appropriate number types (#366) (@michaelpj) | ||
| * Fix for #374 (#376) (@pepeiborra) | ||
| * Fix virtual file name adding .hs extension (#364) (@heitor-lassarote, @jneira) |
There was a problem hiding this comment.
Suggested change
| * Fix virtual file name adding .hs extension (#364) (@heitor-lassarote, @jneira) | |
| * Fix virtual file name adding .hs extension (#364) (@heitor-lassarote) |
I did not meaningful change in that pr (afair :-P)
jneira
reviewed
Dec 28, 2021
jneira
approved these changes
Dec 28, 2021
We have to adapt hls to last changes here haskell/haskell-language-server#2494, no? |
Oh hm, yes, I guess I could have done that! I just assumed we wanted it to be cleverer than that :p well, I did it manually this time!
Yeah, exactly, that's what I'm doing. |
|
HLS on the branch builds and the tests pass, let's do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lspto matchlsp-typesGenChangelogsnice with multiple packages)CONTRIBUTINGI'm going to build HLS with this branch just to check that I haven't messed anything up.