-
Notifications
You must be signed in to change notification settings - Fork 93
Replace Word32 with a newtype #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Builds are generally passing in haskell/haskell-language-server#2494, so I think this is safe to merge, and then we should be okay to do a release and then fix up HLS. |
Introducing |
Ugh, how annoying. I was hoping that it was a simple enough package that it would just "keep working". I was really hoping to avoid writing the plumbing for a 31-bit word myself... |
Unexpectedly, older releases of |
Maybe I'll ask if I can take over |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, do you think we can continue using OddWord?
Well if it becomes a blocker we can always do the boilerplate
Yes, ripping it out later would be a localized change. Maybe the LSP people will hear my plea and change the upper bound (yeah right). |
Any particular reason to prefer |
Thanks, it didn't occur to me to look for a modular arithmetic package, that makes a lot of sense in fact!
|
This time with the correct (strange) bounds.
22e4db7
to
b48cf78
Compare
This time with the correct (strange) bounds.