Skip to content

Clean up module dependency cycles introduced by haskell-{process,session,interactive-mode} #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hvr opened this issue Jul 20, 2013 · 2 comments
Closed

Clean up module dependency cycles introduced by haskell-{process,session,interactive-mode} #187

hvr opened this issue Jul 20, 2013 · 2 comments
Assignees
@hvr
Labels
repl (interactive)

Comments

@hvr
Copy link
Member

hvr commented Jul 20, 2013

The graph diagram below shows the current module inter-dependencies, and is generated by visualizing require (black edges) and declare-function (red dashed edges) statements contained in the *.el files (i.e. the nodes):

depgraph

As can be clearly seen the current integration of the haskell-{process,session,interactive-mode} cluster currently destroys an otherwise DAG-like dependency graph.
@ghost ghost assigned hvr Jul 20, 2013
hvr added a commit that referenced this issue Jul 20, 2013
@hvr
Add new haskell-utils.el module for addressing #187
82e2e97 
This module's purpose is to provide a place for helper functions which
are general enough to be usable by multiple modules and/or to
alleviate circular module dependency problems.
hvr added a commit that referenced this issue Jul 20, 2013
@hvr
Move haskell-read-directory-name to new haskell-utils.el
c440796 
This addresses #187 by removing the haskell-cabal->haskell-process
dependency.
hvr referenced this issue Jul 22, 2013
@chrisdone
Added `haskell-rgrep' for grepping the effective project
1bcabce 
I've been using this function for some months, might as well add it to
haskell-mode. I tend to use the keybinding M-, as a kind of complement
to M-.
@chrisdone chrisdone mentioned this issue Nov 29, 2014
Closed
@gracjan
Copy link
Contributor

gracjan commented Mar 1, 2015

@hvr @chrisdone: is this one done?

@gracjan
Copy link
Contributor

gracjan commented Mar 27, 2015

I guess it is done. Reopen if you disagree.

@gracjan gracjan closed this as completed Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvr hvr

Labels
repl (interactive)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hvr @gracjan