haskell-align-imports doesn't work as advertised

[hvr]

According to the commentary,

import One
import Two as A
import qualified Three
import qualified Four as PRELUDE
import Five (A)
import Six (A,B)
import qualified Seven (A,B)
import "abc" Eight
import "abc" Nine as TWO
import qualified "abc" Ten
import qualified "defg" Eleven as PRELUDE
import "barmu" Twelve (A)
import "zotconpop" Thirteen (A,B)
import qualified "z" Fourteen (A,B)
import Fifteen hiding (A)
import Sixteen as TWO hiding (A)
import qualified Seventeen hiding (A)
import qualified Eighteen as PRELUDE hiding (A)
import "abc" Nineteen hiding (A)
import "abc" Twenty as TWO hiding (A)

is supposed to be transformed into

import                  One
import                  Two       as A
import qualified        Three
import qualified        Four      as PRELUDE
import                  Five      (A)
import                  Six       (A,B)
import qualified        Seven     (A,B)
import "abc"            Eight
import "abc"            Nine      as TWO
import qualified "abc"  Ten
import qualified "defg" Eleven    as PRELUDE
import "barmu"          Twelve    (A)
import "zotconpop"      Thirteen  (A,B)
import qualified "z"    Fourteen  (A,B)
import                  Fifteen   hiding (A)
import                  Sixteen   as TWO hiding (A)
import qualified        Seventeen hiding (A)
import qualified        Eighteen  as PRELUDE hiding (A)
import "abc"            Nineteen  hiding (A)
import "abc"            Twenty    as TWO hiding (A)

However, the current implementation only aligns the module names:

import                  One
import                  Two as A
import qualified        Three
import qualified        Four as PRELUDE
import                  Five (A)
import                  Six (A,B)
import qualified        Seven (A,B)
import "abc"            Eight
import "abc"            Nine as TWO
import qualified "abc"  Ten
import qualified "defg" Eleven as PRELUDE
import "barmu"          Twelve (A)
import "zotconpop"      Thirteen (A,B)
import qualified "z"    Fourteen (A,B)
import                  Fifteen hiding (A)
import                  Sixteen as TWO hiding (A)
import qualified        Seventeen hiding (A)
import qualified        Eighteen as PRELUDE hiding (A)
import "abc"            Nineteen hiding (A)
import "abc"            Twenty as TWO hiding (A)

[chrisdone]

Yeah, I know it.

[hvr]

I vaguely remember, that this used to work long time ago... did something change?

[chrisdone]

At some point it stopped working but I was too busy to investigate why.

[brendanhay]

FYI this version works as advertised.

[chrisdone]

Here is a fix. After looking into it and testing the behaviour on some real code, I remember why I disabled this intentionally. Padding after the module name quickly becomes obnoxious when module names are long and qualification is used, you end up with floating "as" that really dangle by themselves. Similar to how you can align -> in a case but sometimes it just looks stupid and judgment is needed.

But I've enabled an option to support that again as haskell-align-imports-pad-after-name and updated the documentation.

[brendanhay]

Excellent, thanks alot.

[gracjan]

Can this be closed?