Skip to content

Deprecate haskell-site-file.el #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hvr opened this issue Jun 1, 2013 · 3 comments
Closed

Deprecate haskell-site-file.el #156

hvr opened this issue Jun 1, 2013 · 3 comments
Assignees
@hvr

Comments

@hvr
Copy link
Member

hvr commented Jun 1, 2013

If we can drop support for Emacs versions prior to 23.1 (which was released in 4 years ago, and the earliest version for which package.el/ELPA support is possible), we should get rid of the autoloads haskell-site-file.el file altogether (it was removed from the git repo via ae7cee0) as this file becomes obsolete thanks to package.el:

I've been reading up on Preparing Lisp code for distribution and found out that if we generate a .tarball following the requirements for Multi-file Packages we don't have to generate the autoloads at all. In the contrary:

Do not include any .elc files in the package. Those are created when the package is installed. Note that there is no way to control the order in which files are byte-compiled.

Do not include any file named name-autoloads.el. This file is reserved for the package's autoload definitions (see Packaging Basics). It is created automatically when the package is installed, by searching all the Lisp files in the package for autoload magic comments.

Even if we don't upload the package .tar-file to any package repository, it can still install be installed directly via M-x package-install-file.

Therefore I propose that the Makefile build-system shall support the following two use-cases:

  • Generate easy to install M-x package-install-file-compatible .tar file for end-users (and Linux distributions)
  • Generate "in-place" distribution for developers (basically what make all does now already)

This would also help reduce the hacks currently contained in Makefile (see 896c422 and 8d3edf5)
@ghost ghost assigned hvr Jun 1, 2013
@chrisdone
Copy link
Member

Sounds good to me.

hvr added a commit that referenced this issue Jun 1, 2013
@hvr
Add new make package target for creating ELPA packages
29ff368 
This new target generates a package distribution file

  haskell-mode-<release-version>.tar

(where <release-version> is inferred by `git describe --tags --abbrev=0`)
according to the guidelines described in

  http://www.gnu.org/software/emacs/manual/html_node/elisp/Packaging.html

which can then be installed directly via
`M-x package-install-file` (or uploaded to Marmalade)

This addresses #156 and #92
akamch added a commit to akamch/haskell-mode that referenced this issue Jun 5, 2013
@akamch
Replace interactive-p with called-interactively-p
16c6b41 
If support for Emacs versions prior to 23.1 is to be dropped (haskell#156) than
interactive-p (obsolete as of 23.2) can be removed.
akamch added a commit to akamch/haskell-mode that referenced this issue Jun 5, 2013
@akamch
Replace interactive-p with called-interactively-p
4b1a43b 
If support for Emacs versions prior to 23.1 is to be dropped (haskell#156) than
interactive-p (obsolete as of 23.2) can be removed.
akamch added a commit to akamch/haskell-mode that referenced this issue Jun 5, 2013
@akamch
Replace interactive-p with called-interactively-p
5179049 
If support for Emacs versions prior to 23.1 is to be dropped (haskell#156) than
interactive-p (obsolete as of 23.2) can be removed.
hvr added a commit that referenced this issue Jun 9, 2013
@hvr
Rename haskell-site-file to haskell-mode-autoloads
e4418c3 
And update the instructions in the README

This matches the convention used by the elisp package system which
generates a `haskell-mode-autoloads.el` file during package install.

This is related to #156
@bergey
Copy link
Contributor

bergey commented Jun 9, 2013

The README still references building the haskell-site-file with make

hvr added a commit that referenced this issue Jun 9, 2013
@hvr
Fixup forgotten references to haskell-site-file
2aed25d 
This was overlooked in e4418c3 (re #156)
@hvr
Copy link
Member Author

hvr commented Jun 9, 2013

@bergey thx!

@hvr hvr closed this as completed in 596e797 Jun 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvr hvr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chrisdone @bergey @hvr