Skip to content

ghcide needs prettyprinter 1.7 #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2022
Merged

ghcide needs prettyprinter 1.7 #3430

merged 1 commit into from
Dec 30, 2022

Conversation

juhp
Copy link
Contributor

@juhp juhp commented Dec 30, 2022

Since HLS 1.7, prettyprinter 1.7 is actually needed in order to build:

src/Development/IDE/Plugin/HLS.hs:44:1: error:
    Could not load module ‘Prettyprinter.Render.String’
    It is a member of the hidden package ‘prettyprinter-1.7.1’.
    Perhaps you need to add ‘prettyprinter’ to the build-depends in your .cabal file.
    It is a member of the hidden package ‘prettyprinter-1.7.1’.
    Perhaps you need to add ‘prettyprinter’ to the build-depends in your .cabal file.
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
44 | import           Prettyprinter.Render.String  (renderString)
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: cabal: Failed to build ghcide-1.9.0.0 (which is required by
exe:haskell-language-server-wrapper from haskell-language-server-1.9.0.0 and
exe:haskell-language-server from haskell-language-server-1.9.0.0). See the
build log above for details.

(I have been carrying a patch for this in my Fedora copr repo, though current Fedora releases are now all on 1.7.)

Since HLS 1.7, prettyprinter 1.7 is actually needed in order to build:
```
src/Development/IDE/Plugin/HLS.hs:44:1: error:
    Could not load module ‘Prettyprinter.Render.String’
    It is a member of the hidden package ‘prettyprinter-1.7.1’.
    Perhaps you need to add ‘prettyprinter’ to the build-depends in your .cabal file.
    It is a member of the hidden package ‘prettyprinter-1.7.1’.
    Perhaps you need to add ‘prettyprinter’ to the build-depends in your .cabal file.
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
44 | import           Prettyprinter.Render.String  (renderString)
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: cabal: Failed to build ghcide-1.9.0.0 (which is required by
exe:haskell-language-server-wrapper from haskell-language-server-1.9.0.0 and
exe:haskell-language-server from haskell-language-server-1.9.0.0). See the
build log above for details.
```
@juhp juhp requested a review from pepeiborra as a code owner December 30, 2022 06:17
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pepeiborra pepeiborra merged commit 90d17fe into haskell:master Dec 30, 2022
@juhp juhp deleted the patch-2 branch December 30, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants