Skip to content

Enable hls-stylish-haskell-plugin with ghc 9.2 #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 19, 2022

Conversation

July541
Copy link
Collaborator

@July541 July541 commented Apr 18, 2022

No description provided.

@July541 July541 requested a review from Ailrun as a code owner April 18, 2022 10:50
@July541 July541 mentioned this pull request Apr 18, 2022
@July541 July541 requested a review from Anton-Latukha as a code owner April 18, 2022 12:18
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, although we'll have to see if it all builds nicely once haskell.org is back.

@wz1000
Copy link
Collaborator

wz1000 commented Apr 19, 2022

The flags job for 9.2.2 fails to resolve dependencies. Does the index state need to updated?

cabal: Could not resolve dependencies:
[__0] trying: ghcide-1.6.0.1 (user goal)
[__1] trying: hie-bios-0.9.1 (dependency of ghcide)
[__2] trying: base-4.16.1.0/installed-4.16.1.0 (dependency of ghcide)
[__3] trying: aeson-2.0.3.0 (dependency of ghcide)
[__4] trying: hls-stylish-haskell-plugin-1.0.1.0 (user goal)
[__5] next goal: stylish-haskell (dependency of hls-stylish-haskell-plugin)
[__5] rejecting: stylish-haskell-0.13.0.0 (conflict: aeson==2.0.3.0,
stylish-haskell => aeson>=0.6 && <1.6)
[__5] skipping: stylish-haskell-0.12.2.0, stylish-haskell-0.12.1.0,
stylish-haskell-0.12.0.0, stylish-haskell-0.11.0.3, stylish-haskell-0.11.0.0,
stylish-haskell-0.10.0.0, stylish-haskell-0.9.4.4, stylish-haskell-0.9.4.3,
stylish-haskell-0.9.4.0, stylish-haskell-0.9.3.0, stylish-haskell-0.9.2.2,
stylish-haskell-0.9.2.1, stylish-haskell-0.9.2.0, stylish-haskell-0.9.1.1,
stylish-haskell-0.9.1.0, stylish-haskell-0.9.0.2, stylish-haskell-0.9.0.1,
stylish-haskell-0.9.0.0, stylish-haskell-0.8.1.0, stylish-haskell-0.8.0.0,
stylish-haskell-0.7.1.0, stylish-haskell-0.7.0.0, stylish-haskell-0.6.5.0,
stylish-haskell-0.6.4.0, stylish-haskell-0.6.3.0, stylish-haskell-0.6.2.0,
stylish-haskell-0.6.1.0, stylish-haskell-0.6.0.0, stylish-haskell-0.5.17.0,
stylish-haskell-0.5.16.0, stylish-haskell-0.5.15.2, stylish-haskell-0.5.15.1,
stylish-haskell-0.5.15.0, stylish-haskell-0.5.14.4, stylish-haskell-0.5.14.3,
stylish-haskell-0.5.14.2, stylish-haskell-0.5.14.1, stylish-haskell-0.5.14.0,
stylish-haskell-0.5.13.0, stylish-haskell-0.5.12.0, stylish-haskell-0.5.11.2,
stylish-haskell-0.5.11.1, stylish-haskell-0.5.11.0, stylish-haskell-0.5.10.2,
stylish-haskell-0.5.10.1, stylish-haskell-0.5.10.0, stylish-haskell-0.5.9.1,
stylish-haskell-0.5.9.0, stylish-haskell-0.5.8.0, stylish-haskell-0.5.7.0,
stylish-haskell-0.5.6.1, stylish-haskell-0.5.6.0, stylish-haskell-0.5.5.2,
stylish-haskell-0.5.5.1, stylish-haskell-0.5.5.0, stylish-haskell-0.5.4.0,
stylish-haskell-0.5.3.0, stylish-haskell-0.5.2.0, stylish-haskell-0.5.1.0,
stylish-haskell-0.5.0.2, stylish-haskell-0.5.0.1, stylish-haskell-0.5.0.0,
stylish-haskell-0.4.0.0, stylish-haskell-0.3.2.0, stylish-haskell-0.3.1.0,
stylish-haskell-0.3.0.0, stylish-haskell-0.2.0.2, stylish-haskell-0.2.0.1,
stylish-haskell-0.2.0.0 (has the same characteristics that caused the previous
version to fail: excludes 'aeson' version 2.0.3.0)
[__5] rejecting: stylish-haskell-0.1.1.0 (conflict: hls-stylish-haskell-plugin
=> stylish-haskell^>=0.12 || ^>=0.13 || ^>=0.14)
[__5] skipping: stylish-haskell-0.1.0.0 (has the same characteristics that
caused the previous version to fail: excluded by constraint '^>=0.12 ||
^>=0.13 || ^>=0.14' from 'hls-stylish-haskell-plugin')
[__5] fail (backjumping, conflict set: aeson, hls-stylish-haskell-plugin,
stylish-haskell)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: aeson, stylish-haskell, hie-bios,
ghcide, base, hls-stylish-haskell-plugin
Try running with --minimize-conflict-set to improve the error message.

@michaelpj michaelpj added the merge me Label to trigger pull request merge label Apr 19, 2022
@mergify mergify bot merged commit fbcd3a4 into haskell:master Apr 19, 2022
sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request May 21, 2022
* Enable hls-stylish-haskell-plugin on ghc-9.2

* Remove sha256 notation

* Update project file

* Update nix file

* Enable tests

* update index-state

* Rerun ci

Co-authored-by: wz1000 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants