Skip to content

Hlinting partial functions #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 30, 2022
Merged

Hlinting partial functions #2634

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b611f74
Ban new uses of `tail`
mxxun Jan 23, 2022
37f8841
Merge branch 'master' into hlint-partials
jneira Jan 25, 2022
52617e2
Merge branch 'master' into hlint-partials
jneira Jan 30, 2022
bc2006c
Merge branch 'master' into hlint-partials
jneira Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ghcide/.hlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,21 @@
- {name: unsafeCoerce, within: [Ide.Plugin.Eval.Code, Development.IDE.Core.Compile, Development.IDE.Types.Shake]}
# Things that are a bit dangerous in the GHC API
- {name: nameModule, within: []}
# Partials and their legacy locations
- name: tail
within:
- Development.Benchmark.Rules
- Development.IDE.Plugin.CodeAction
- Development.IDE.Plugin.CodeAction.ExactPrint
- Development.IDE.Session
# ghcide/test/exe
- Main
# plugins/hls-tactics-plugin/test
# - UnificationSpec

# We really do not want novel usages of restricted functions, and mere
# Warning is not enough to prevent those consistently; you need a build failure.
- error: {name: Avoid restricted function}

# Add custom hints for this project
#
Expand Down