Skip to content

Test only last ghc minor version and fix windows cache #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 11, 2021
Merged

Test only last ghc minor version and fix windows cache #1173

merged 10 commits into from
Jan 11, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Jan 8, 2021 •
edited
Loading

@jneira jneira requested a review from pepeiborra January 8, 2021 12:51
@jneira
Copy link
Member Author

jneira commented Jan 8, 2021

In this repo the test workflow takes 46 min: https://github.com/haskell/haskell-language-server/actions/runs/472245636

@jneira jneira requested a review from Ailrun January 8, 2021 19:22
pepeiborra
pepeiborra reviewed Jan 8, 2021
View reviewed changes
pepeiborra
pepeiborra reviewed Jan 8, 2021
View reviewed changes
pepeiborra
pepeiborra reviewed Jan 8, 2021
View reviewed changes
.github/workflows/test.yml Outdated
# run the tests without parallelism to avoid running out of memory
run: cabal test ghcide --test-options="-j1 --rerun-update" || cabal test ghcide --test-options="-j1 --rerun" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test ghcide --test-options="-j1 --rerun"

- name: Test func-test suite
shell: bash
if: ${{ !matrix.ghc-lib && matrix.test }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: ${{ !matrix.ghc-lib && matrix.test }}
if: ${{ matrix.test }}

pepeiborra
pepeiborra reviewed Jan 8, 2021
View reviewed changes
.github/workflows/test.yml Outdated

- name: Test wrapper-test suite
shell: bash
if: ${{ !matrix.ghc-lib && matrix.test }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: ${{ !matrix.ghc-lib && matrix.test }}
if: ${{ matrix.test }}

pepeiborra
pepeiborra approved these changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Ailrun
Ailrun approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Jan 9, 2021
@Ailrun
Copy link
Member

Ailrun commented Jan 10, 2021

It looks like we should update .github/mergify.yml too, as the file now contains some outdated ci test entries.

@Ailrun
Copy link
Member

Ailrun commented Jan 10, 2021 •
edited
Loading

And could you update the GitHub setting for the required checks (I don't have the permission)? It looks like the removed checks remain required.

@jneira
Copy link
Member Author

jneira commented Jan 11, 2021

It seems the mergify config from master is not replaced by this one, weird...
I think the right way is doing another pull request only to remove them and rebase this one.

jneira added a commit to jneira/haskell-language-server that referenced this pull request Jan 11, 2021
@jneira
Remove runs dropped by haskell#1173
ec2c668 
The mergify config is not completely updated and is required
to remove them to unblock
haskell#1173
@jneira jneira mentioned this pull request Jan 11, 2021
Merged
jneira added a commit that referenced this pull request Jan 11, 2021
@jneira
Merge pull request #1194 from jneira/remove-old-checks
16aee6e 
Remove runs dropped by #1173
@jneira
Copy link
Member Author

jneira commented Jan 11, 2021 •
edited
Loading

@Ailrun is right, we had to update checks in github settings (in addition to mergify)
In fact we should update there all new checks added with this pr

@jneira jneira merged commit fde10fa into haskell:master Jan 11, 2021
@jneira
Copy link
Member Author

jneira commented Jan 11, 2021 •
edited
Loading

I've changed the required checks in github settings to match the established ones with this pr.
@Ailrun you should have admin rights to see and change them now, please take a look to confirm they are correct 😺

@Ailrun
Copy link
Member

Ailrun commented Jan 11, 2021

Checked. The updated setting looks good to me. Thank you for the CI update!

fendor pushed a commit to fendor/haskell-language-server that referenced this pull request Jan 11, 2021
@jneira @fendor
Remove runs dropped by haskell#1173
ce8ca81 
The mergify config is not completely updated and is required
to remove them to unblock
haskell#1173
@jneira jneira deleted the fix-win-cache branch January 15, 2021 06:50
@jneira jneira removed the merge me Label to trigger pull request merge label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

@Ailrun Ailrun Ailrun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jneira @Ailrun @pepeiborra