Skip to content

Completion provenance for local definition is Just ModuleName instead of just ModuleName #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
expipiplus1 opened this issue Dec 17, 2020 · 3 comments · Fixed by #2848
Closed
Labels
component: hls-module-name-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@expipiplus1
Copy link
Contributor

To reproduce:

Create the following module:

module Foo
  where

bar = ()

foo = ba
  • Trigger completion for ba
  • Observe that the provenance of bar is Just Foo instead of just Foo

image

@jneira
Copy link
Member

jneira commented Dec 17, 2020

Thanks to test the new version and report the issues you have found (it seems all of them are related with completions). The fix could be added to the new completion plugin as the rest: #670

@jneira jneira added component: plugins type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Dec 17, 2020
@July541
Copy link
Collaborator

July541 commented Apr 21, 2022

I think it not exist now, maybe we can add a regression test to close it.

image

@July541
Copy link
Collaborator

July541 commented Apr 21, 2022

Completion doc does not display correctly with the local module.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: hls-module-name-plugin type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants