Skip to content

Desugarer warnings #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
georgefst opened this issue Dec 16, 2020 · 3 comments · Fixed by #677 or #684
Closed

Desugarer warnings #676

georgefst opened this issue Dec 16, 2020 · 3 comments · Fixed by #677 or #684
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@georgefst
Copy link
Collaborator

Has haskell/ghcide#107 crept back in?

Just updated to HLS 0.7 via the VScode plugin and I'm back to not seeing any "incomplete pattern match" warning on e.g.:

{-# OPTIONS_GHC -Wall #-}

f = \case
    Nothing -> ()

😢
@georgefst
Copy link
Collaborator Author

I'm back to not seeing any "incomplete pattern match" warning

Unless I enable TemplateHaskell. But that wasn't necessary in 0.6.

@wz1000
Copy link
Collaborator

wz1000 commented Dec 16, 2020 •
edited
Loading

This is probably due to haskell/ghcide#904 , so HLS has to be modified add action kick to its rules, as done here: https://github.com/haskell/ghcide/blob/6365d3cc61e98515333f5fc77b1dabf64475b1fa/exe/Main.hs#L121

/cc @jneira unfortunately this probably warrants another release :(

@wz1000 wz1000 transferred this issue from haskell/ghcide Dec 16, 2020
@wz1000 wz1000 pinned this issue Dec 16, 2020
@wz1000 wz1000 mentioned this issue Dec 16, 2020
Merged
wz1000 added a commit to wz1000/haskell-language-server that referenced this issue Dec 16, 2020
@wz1000
Restore kick (haskell#676)
c64490f
@Ailrun Ailrun added status: blocked Not actionable, because blocked by upstream/GHC etc. type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. component: ghcide and removed status: blocked Not actionable, because blocked by upstream/GHC etc. labels Dec 16, 2020
@jneira
Copy link
Member

jneira commented Dec 16, 2020

No worries, i hope this one will be less problematic 🤞

jneira added a commit that referenced this issue Dec 17, 2020
@jneira
Merge pull request #677 from wz1000/fix-desugarer
bf8ce83 
Restore kick (#676)
@jneira jneira mentioned this issue Dec 17, 2020
Merged
@jneira jneira unpinned this issue Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore kick (#676) wz1000/haskell-language-server
Prepare 0.7.1 jneira/haskell-language-server
4 participants
@jneira @wz1000 @Ailrun @georgefst