-
-
Notifications
You must be signed in to change notification settings - Fork 391
Support for GHC-8.10.3 #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Out of curiosity - do you know if GHC-8.10.3 is coming, and if so - roughly when? |
it still has not been released |
would be great to also support non-moving GC once it lands |
What needs to be done to support the non-moving GC? Do you want to enable it by default? |
Probably only a flag to enable it if compiled with GHC 8.10.3+ and some testing that it works. |
What needs to be done, now it has been released? |
wait for secondary releases in package managers used by ci, chocolatey f.e. for Windows |
Ok. Can we do a release that installs for non-windows (e.g. ghcup installed), and then follow up with the rest? Not sure how long the wait will be. |
yeah, GitHub macos uses ghcup, Linux hvr ppa and Windows choco, circle ci stack (so it needs only a working stack.yaml) |
I am preparing the support here: https://github.com/jneira/haskell-language-server/tree/ghc-8.10.3 but no ci provider is ready yet nor stack. You can set |
@jneira Thanks, I tried your ghc-8.10.3 branch, and it works :-) |
yeah, we have to at least, try it out, thanks to note it ghc-8.10.3 is already in chocolatey, so we only have to wait for support in github actions and stack. |
Issue in github virtual envs: actions/runner-images#2353 |
Issue in haskell docker images asking for support for ghc-8.10.3: haskell/docker-haskell#31 |
* Tests for issue 310 (misleading hover on inner signature) The most important pair of tests here is the "inner signature" pair. The others serve mainly to document, compare and contrast what is happening in related situations. In summary, hover and gotoDef + on inner signatures: give type and location information for the outer definition; this is misleading, + on outer signatures: give no information at all, + on inner definitions: give correct information for the inner definition, + on outer definitions: give correct information for the outer definition. Should hover and gotoDef do anything at all for signatures? or is the current behaviour for outer signatures (doing nothing at all) what we want? * Require signature hover/gotoDef to point to first clause of definition * Remove perhaps superfluous tests for definitions
stack became able to install ghc 8.10.3 in recent days ( |
@simonmichael thanks for noting it, we are building with stack using the compiler option in circleci: https://github.com/haskell/haskell-language-server/pull/699/files#diff-ceaaa3c4bbd2e628e86a2d16f3afb57e89317b8d442abff3d8a2ca1425b704c7 |
last hls version already supports ghc-8.10.3 |
Since 8.10.2 turned out to be a short-term update. and 8.10.3 is about to be released and become "it", HLS should support it. ;-)
The text was updated successfully, but these errors were encountered: