Skip to content

Renaming a record (using F2 button in vscode) gives strange results #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sorokin-Anton opened this issue Aug 15, 2022 · 2 comments
Closed
Labels
component: hls-rename-plugin status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@Sorokin-Anton
Copy link

Sorokin-Anton commented Aug 15, 2022

Your environment

Which OS do you use?

Windows 10, WSL
Which version of GHC do you use and how did you install it?

9.2.4, ghcup
How is your project built (alternative: link to the project)?
stack
Which LSP client (editor/plugin) do you use?
vscode

Which version of HLS do you use and how did you install it?

1.7.0.0 from ghcup

Steps to reproduce

Create a datatype with records, like

data TetrisConfig = TetrisConfig {boardSize :: (Int, Int), cellSide :: Float}

move cursor to record (boardSize) and try to rename it to qqq via F2 button

Expected behaviour

data TetrisConfig = TetrisConfig {qqq:: (Int, Int), cellSide :: Float}

Actual behaviour

data TetrisConfig = qqq {qqq :: (Int, Int), qqq :: Float}

and all other usages of constructor and all records are renamed

Debug information

@Sorokin-Anton Sorokin-Anton added status: needs triage type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. labels Aug 15, 2022
@July541
Copy link
Collaborator

July541 commented Aug 15, 2022

Duplicate to #2915?

@July541 July541 added component: hls-rename-plugin status: needs info Not actionable, because there's missing information and removed status: needs triage labels Aug 15, 2022
@michaelpj
Copy link
Collaborator

Yep, this is a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: hls-rename-plugin status: needs info Not actionable, because there's missing information type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

3 participants