Skip to content

Re-exported symbol hover ghcide test is flaky on Windows #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
July541 opened this issue Jun 28, 2022 · 0 comments · Fixed by #3008
Closed

Re-exported symbol hover ghcide test is flaky on Windows #2997

July541 opened this issue Jun 28, 2022 · 0 comments · Fixed by #3008
Labels
component: ghcide os: windows type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@July541
Copy link
Collaborator

July541 commented Jun 28, 2022 •
edited
Loading

Recently windows tests are unstable due to https://github.com/haskell/haskell-language-server/blob/master/ghcide/test/exe/Main.hs#L4442

It's a test for the definition of reexported symbol. I've checked that both the expected result and the real result are all acceptable for goto definition behavior.

Some observations:

  1. It failed most time.
  2. Retry has a chance to pass the test.

Known affected prs:

  1. Don't use typecheck rule for non FOIs in refine imports plugin #2995
  2. Log response errors returned from Plugins #2988
  3. Remove some partial functions from Shake.hs #2986
  4. Turn HLS-wrapper into an LSP Server #2960
@July541 July541 added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. os: windows component: ghcide labels Jun 28, 2022
@michaelpj michaelpj changed the title Test on Windows has a flaky item Re-exported symbol hover ghcide test is flaky on Windows Jun 29, 2022
@kokobd kokobd mentioned this issue Jul 1, 2022
Merged
michaelpj added a commit to michaelpj/haskell-language-server that referenced this issue Jul 1, 2022
@michaelpj
Disable flaky test on Windows
8986d66 
I don't think anyone is going to fix this soon, let's just disable it so
we can move on.

Fixes haskell#2997.
@michaelpj michaelpj mentioned this issue Jul 1, 2022
Merged
michaelpj added a commit to michaelpj/haskell-language-server that referenced this issue Jul 1, 2022
@michaelpj
Disable flaky test on Windows
4204a8d 
I don't think anyone is going to fix this soon, let's just disable it so
we can move on.

Fixes haskell#2997.
@mergify mergify bot closed this as completed in #3008 Jul 4, 2022
mergify bot added a commit that referenced this issue Jul 4, 2022
@michaelpj @mergify
Disable flaky test on Windows (#3008)
ffef347 
I don't think anyone is going to fix this soon, let's just disable it so
we can move on.

Fixes #2997.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
hololeap pushed a commit to hololeap/haskell-language-server that referenced this issue Aug 26, 2022
@michaelpj @mergify @hololeap
Disable flaky test on Windows (haskell#3008)
70f699c 
I don't think anyone is going to fix this soon, let's just disable it so
we can move on.

Fixes haskell#2997.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ghcide os: windows type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable flaky test on Windows michaelpj/haskell-language-server
1 participant
@July541