Minor "import action" formatting bug #2414
Comments
jneira
added
type: bug
|
Minor but interesting bug, have you any intuition about what triggers it, the place of the |
jneira
added
status: regression test needed
level: easy
|
I think so, now that I tried it out again the explicit export doesn't seem to matter. I also feel like this is a regression, but not 100% sure. |
|
I have a very strong feeling that this happens when )
whereand does not happen when they are on the name line: ) whereormolu formats export lists the first way and the initial import is broken. If you already have imports, the positioning of the |
|
A quick experiment shows that for a file like this, nothing represents the module Asdf
(f)
where
f :: Int64 -> Int64
f = idWhen there is no existing import declaration, the current implementation uses So if there is no way to extract the location of |
|
By the way, linking a related issue #2425 to make the context clearer. |
|
The recommended solution is to use We already have an exactprint function to extend imports that can serve as example: |
* #2414 fix new import position * fix auto import for ghc version < 9.2 * re-fix it for ghc-9.2 * handle comments * add more comments * reword comments of findPositionNoImports Co-authored-by: Pepe Iborra <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* haskell#2414 fix new import position * fix auto import for ghc version < 9.2 * re-fix it for ghc-9.2 * handle comments * add more comments * reword comments of findPositionNoImports Co-authored-by: Pepe Iborra <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
HLS
--versionYour environment
Output of
haskell-language-server --probe-toolsorhaskell-language-server-wrapper --probe-tools:tauren :: /tmp » haskell-language-server-wrapper --probe-tools haskell-language-server version: 1.5.0.0 (GHC: 8.10.7) (PATH: /home/googleson78/.ghcup/bin/haskell-language-server-wrapper-1.5.0) (GIT hash: 311107eabbf0537e0c192b2c377d282505b4eff1) Tool versions found on the $PATH cabal: 3.6.2.0 stack: 2.7.3 ghc: 8.10.7Which OS do you use:
Debian
Which lsp-client do you use:
nvim, LanguageClient-neovim
Describe your project:
Reproduces with a standalone file and in a stack project
Steps to reproduce
Try to use the import action for
Int64with these file contents.Expected behaviour
(or some other valid result)
Actual behaviour
Include debug information
Debug output:
The text was updated successfully, but these errors were encountered: