Skip to content

Adding missing constraint to type signature is broken when "forall" is present #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jhrcek opened this issue Jan 7, 2021 · 0 comments · Fixed by #1177
Closed

Adding missing constraint to type signature is broken when "forall" is present #1164

jhrcek opened this issue Jan 7, 2021 · 0 comments · Fixed by #1177
Labels
type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@jhrcek
Copy link
Collaborator

jhrcek commented Jan 7, 2021

Reproducer

Reproduced with
haskell-language-server version: 0.8.0.0 (GHC: 8.8.4) (PATH: /home/jhrcek/.local/bin/haskell-language-server) (GIT hash: bde552b)

NOTE: previously I've made this code action more robust by fixing the behavior when context is formatted over multiple lines (haskell/ghcide#839). But it seems some more work is needed. I'll probably get to fixing this over the weekend.
@Ailrun Ailrun added the type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. label Jan 7, 2021
jhrcek added a commit to jhrcek/haskell-language-server that referenced this issue Jan 9, 2021
@jhrcek
Make adding missing constraints work when 'forall' is present (fixes h…
da91efa 
…askell#1164)
jhrcek added a commit to jhrcek/haskell-language-server that referenced this issue Jan 9, 2021
@jhrcek
Make adding missing constraints work when 'forall' is present (fixes h…
58f01b7 
…askell#1164)
@jhrcek jhrcek mentioned this issue Jan 9, 2021
Merged
@mergify mergify bot closed this as completed in #1177 Jan 9, 2021
mergify bot added a commit that referenced this issue Jan 9, 2021
@jhrcek @mergify
Make adding missing constraint work in presence of 'forall' (fixes #1164
54be003 
) (#1177)

* Make adding missing constraints work when 'forall' is present (fixes #1164)

* Improve comment

* Revert range change

* Don't use code action descr. as test name

* GHC 8.10+ doesn't have splitLHsForAllTy

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
2 participants
@jhrcek @Ailrun