This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Support for Pattern Synonyms #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It turns out that one does not simply add a new Symbol Kind to Microsoft LSP. I have removed custom Symbol Kind and ended up using Function kind for pattern synonyms. Please merge this pull request if you consider it appropriate. |
anton-dessiatov
changed the title
|
Whoops, it fails for GHC 8.6+. Will fix now. |
|
Fixed, but leaved out an 'error' call in case GHC 8.6+ pattern synonym binding evaluates to XPatSynBind. I'm no GHC expert and could use some hint on under which circumstances could it ever evaluate to XPatSynBInd. In my testing environment I never managed to witness that case (tested with GHC 8.6.4). I would say that anyway it's better than before and could probably be merged. |
lukel97
reviewed
Apr 3, 2019
|
Sure! Added tests. |
lukel97
approved these changes
Apr 4, 2019
|
@alanz is this good to merge? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge as is, let's wait if haskell/lsp#143 gets merged.
The thing is that when used on modules that have pattern synonym declarations, hie kept crashing due to
errorcall at line 693 of src/Haskell/Ide/Engine/Plugin/GhcMod.hs file. I have fixed this, but it required to introduce a new SymbolKind inhaskell-lsppackage.This pull request reflects current state of things including referencing my forked version of
haskell-lsp. Once required changes tohaskell-lspget released, I'm going to update this pull request and remove my fork reference.Meanwhile if there are problems with an approach I've taken, I have plenty of time to fix them.