Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

HIE stops working in VS Code when apply-refact fails #451

Closed
txsmith opened this issue Jan 26, 2018 · 0 comments · Fixed by #1220
Closed

HIE stops working in VS Code when apply-refact fails #451

txsmith opened this issue Jan 26, 2018 · 0 comments · Fixed by #1220
Labels
editor: vscode
Milestone
2019-04

Comments

@txsmith
Copy link
Contributor

txsmith commented Jan 26, 2018 •
edited
Loading

I've noticed the following issue with apply-refact: mpickering/apply-refact#33

I'm not sure whether this is intended behavior on the side of apply-refact or not, but...
As soon as apply-refact throws a parse error, HIE stops working completely in VS Code: no more hints or compiler errors are shown, hovering over terms stops working, etc.

It would be very nice if we would not have to reload the VS Code session when an external tool fails in some way.
@txsmith txsmith changed the title HIE stops working in VS Code when apply-refactor fails HIE stops working in VS Code when apply-refact fails Jan 26, 2018
@alanz alanz added this to the 2019-01 milestone Dec 24, 2018
@alanz alanz modified the milestones: 2019-01, 2019-02 Feb 2, 2019
@alanz alanz modified the milestones: 2019-02, 2019-03 Mar 2, 2019
@KillyMXI KillyMXI mentioned this issue Mar 25, 2019
Open
@alanz alanz modified the milestones: 2019-03, 2019-04 Apr 6, 2019
@Hogeyama Hogeyama mentioned this issue Apr 30, 2019
Merged
Hogeyama added a commit to Hogeyama/haskell-ide-engine that referenced this issue Apr 30, 2019
@Hogeyama
Add a test case
4d725b8 
Related to haskell#451, haskell#1220
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
editor: vscode
Projects
None yet
Milestone
2019-04
Development

Successfully merging a pull request may close this issue.

Prevent hie crash if apply-refact crashes Hogeyama/haskell-ide-engine
3 participants
@alanz @nponeccop @txsmith