Fix compilation of hackage-security test suite with Cabal-syntax on Hackage and bump version of hackage-repo-tool before release #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikolaj
changed the title
Mikolaj
changed the title
|
See also haskell/cabal#8371 and haskell/cabal#8370. |
ulysses4ever
approved these changes
Aug 12, 2022
andreasabel
requested changes
Aug 13, 2022
| @@ -1,6 +1,6 @@ | |||
| cabal-version: 1.12 | |||
| name: hackage-security | |||
| version: 0.6.2.1 | |||
| version: 0.6.2.2 | |||
There was a problem hiding this comment.
If you bump the version, you should delete the x-revision field, (or set the revision to 0 I suppose, but I never tried this).
There was a problem hiding this comment.
its not clear to me why there's an x-revision field in the cabal file in the repo at all? typically x-revision is supposed to be managed for you by hackage server.
There was a problem hiding this comment.
Makes it easier to automatically upload the revision with https://github.com/hackage-trustees/hackage-cli
Kleidukos
approved these changes
Aug 13, 2022
|
I wasn't able to revise on Hackage the Cabal-syntax breakage that requires the last commit, so I'm merging with it included, as a workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.