Remove code duplication and unify definition of 'trim' function.

[kczulko]

Attempt to fix #7744 .

That's my first ever cabal PR so I somehow don't know what I'm doing. Just picked up first good-first-issue because I've found this https://twitter.com/bkmlep/status/1432474203245015040

Distribution.Utils.String sounds like a good place for trim but I had to expose this module unfortunately.

This the situation after my change:

Any advice or criticism fully welcomed!

Karol

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

[Mikolaj]

The CI failures seems to be caused by github upgrading to GHC 9.2.1. We'll have to fix our CI.

[Mikolaj]

Please kindly rebase and the two CI failures should be gone.

[jneira]

LGTM, nice clean up, Thanks!

[Mikolaj]

LGTM

[fgaz]

Do we add @since annotations now or on release?

edit: do we even do @since annotations?

[Mikolaj]

It seems we do:

Cabal/src/Distribution/Version.hs:-- @since 3.6.0.0

Not sure about this particular case, because the function was available long before (though from different places).

Anyway, it makes sense to add them ASAP, because we are on fire and the world is falling when we release.

[kczulko]

@Mikolaj
How can I obtain the next release version in order to add @since label?

[Mikolaj]

Oh, I forgot not all people are relaxed regarding time travel. It will be 3.8.