-
Notifications
You must be signed in to change notification settings - Fork 710
make cabal less chatty w.r.t. project files in use #10940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d2194da
to
45dcb0d
Compare
4501f79
to
cc63eaf
Compare
528cf85
to
fae5b09
Compare
Are you still seeing the problems in the CI? As in
|
@Mikolaj yes, that's why the pipelines are currently failing I believe |
I don't think this
|
Oh my, I had a feeling I lost my way in the output... I wonder if in the future we could try to avoid generating +'s like the one that confused me. The actual failure is expected and will be fixed. The reason it wasn't fixed before is that when I ran the testsuite locally --accept'ing the necessary changes, this test failed with an exception in ProjectaOrchestration.hs. This is a discrepancy between my local setup and CI that probably deserves a separate ticket but let's not get bogged down by this. Thanks for unlocking me! Now I can probably finish fixing tests at least. |
2f4b051
to
df7fc70
Compare
map projectConfigPathRoot configFiles | ||
L.\\ ["cabal.project", "cabal.project.local", "cabal.freeze"] | ||
== [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative is something like
map projectConfigPathRoot configFiles | |
L.\\ ["cabal.project", "cabal.project.local", "cabal.freeze"] | |
== [] | |
all ((`elem` cwdProjectFiles) . projectConfigPathRoot) configFiles | |
cwdProjectFiles = ["cabal.project", "cabal.project.local", "cabal.freeze"] |
[path1, path2] -> | ||
text "Configuration is affected by '" <+> path1 <+> text "' and '" <+> path2 <+> text "'" | ||
[path] -> | ||
text "Configuration is affected by '" <+> path <+> text "'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect
text "Configuration is affected by '" <+> path <+> text "'" | |
text "Configuration is affected by '" <> path <> text "'" |
and similar above.
df7fc70
to
5c90821
Compare
I don't see this test in my tree — is it a ghost? |
This is a WIP to fix #10885.
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.