Skip to content

Commit 783c150

Browse files
committed
deprecation and removal messages
1 parent 7845636 commit 783c150

File tree

2 files changed

+32
-29
lines changed

2 files changed

+32
-29
lines changed

Cabal/doc/buildinfo-fields-reference.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ build-tool-depends
4949
build-tools
5050
* monoidal field
5151
* format: ``{comma-separated-list={legacy-exe-dependency}}``
52-
* deprecated since ``cabal-version: 2.0``
53-
* removed in ``cabal-version: 3.0``
52+
* deprecated since ``cabal-version: 2.0``. Please use 'build-tool-depends' field
53+
* removed in ``cabal-version: 3.0``. Please use 'build-tool-depends' field.
5454
* more documentation about :pkg-field:`build-tools`
5555

5656
buildable
@@ -108,8 +108,8 @@ default-language
108108
extensions
109109
* monoidal field
110110
* format: ``{optional-comma-separated-list={language-extension}}``
111-
* deprecated since ``cabal-version: 1.12``
112-
* removed in ``cabal-version: 3.0``
111+
* deprecated since ``cabal-version: 1.12``. Please use 'default-extensions' or 'other-extensions' fields.
112+
* removed in ``cabal-version: 3.0``. Please use 'default-extensions' or 'other-extensions' fields.
113113
* more documentation about :pkg-field:`extensions`
114114

115115
extra-bundled-libraries
@@ -186,8 +186,8 @@ ghcjs-shared-options
186186
hs-source-dir
187187
* monoidal field
188188
* format: ``{optional-comma-separated-list={haskell-string}|[^ ,]+}``
189-
* deprecated since ``cabal-version: 1.2``
190-
* removed in ``cabal-version: 3.0``
189+
* deprecated since ``cabal-version: 1.2``. Please use 'hs-source-dirs'
190+
* removed in ``cabal-version: 3.0``. Please use 'hs-source-dirs' field.
191191
* more documentation about :pkg-field:`hs-source-dir`
192192

193193
hs-source-dirs
@@ -534,7 +534,7 @@ hs-libraries
534534
hugs-options
535535
* monoidal field
536536
* format: ``{optional-comma-separated-list={haskell-string}|[^ ,]+}``
537-
* deprecated since ``cabal-version: 1.22``
537+
* deprecated since ``cabal-version: 1.22``. hugs isn't supported anymore
538538
* more documentation about :pkg-field:`hugs-options`
539539

540540
id

buildinfo-reference-generator/src/Main.hs

Lines changed: 25 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,17 @@ main = do
7575
tellavai Nothing = return ()
7676
tellavai (Just v) = putStrLn $ " * available since ``cabal-version: " ++ showCabalSpecVersion v ++ "``"
7777

78-
telldepr :: Maybe CabalSpecVersion -> IO ()
79-
telldepr Nothing = return ()
80-
telldepr (Just v) = putStrLn $ " * deprecated since ``cabal-version: " ++ showCabalSpecVersion v ++ "``"
81-
82-
tellremo :: Maybe CabalSpecVersion -> IO ()
83-
tellremo Nothing = return ()
84-
tellremo (Just v) = putStrLn $ " * removed in ``cabal-version: " ++ showCabalSpecVersion v ++ "``"
85-
78+
telldepr :: Maybe (CabalSpecVersion, String) -> IO ()
79+
telldepr Nothing = return ()
80+
telldepr (Just (v, d)) = putStrLn $
81+
" * deprecated since ``cabal-version: " ++ showCabalSpecVersion v ++ "``. "
82+
++ d
83+
84+
tellremo :: Maybe (CabalSpecVersion, String) -> IO ()
85+
tellremo Nothing = return ()
86+
tellremo (Just (v,d)) = putStrLn $
87+
" * removed in ``cabal-version: " ++ showCabalSpecVersion v ++ "``. "
88+
++ d
8689

8790
outputReference :: Reference a b -> IO ()
8891
outputReference (Reference ref) = void $ flip Map.traverseWithKey ref $ \fn d -> case d of
@@ -152,30 +155,30 @@ referenceAvailableSince :: CabalSpecVersion -> Reference a b -> Reference a b
152155
referenceAvailableSince v (Reference m) =
153156
Reference (fmap (fieldDescAvailableSince v) m)
154157

155-
referenceRemovedIn :: CabalSpecVersion -> Reference a b -> Reference a b
156-
referenceRemovedIn v (Reference m) =
157-
Reference (fmap (fieldDescRemovedIn v) m)
158+
referenceRemovedIn :: CabalSpecVersion -> String -> Reference a b -> Reference a b
159+
referenceRemovedIn v desc (Reference m) =
160+
Reference (fmap (fieldDescRemovedIn v desc) m)
158161

159-
referenceDeprecatedSince :: CabalSpecVersion -> Reference a b -> Reference a b
160-
referenceDeprecatedSince v (Reference m) =
161-
Reference (fmap (fieldDescDeprecatedSince v) m)
162+
referenceDeprecatedSince :: CabalSpecVersion -> String -> Reference a b -> Reference a b
163+
referenceDeprecatedSince v desc (Reference m) =
164+
Reference (fmap (fieldDescDeprecatedSince v desc) m)
162165

163166
(//) :: Reference a b -> Reference c d -> Reference a b
164167
Reference ab // Reference cd = Reference $ Map.difference ab cd
165168

166169
fieldDescAvailableSince :: CabalSpecVersion -> FieldDesc -> FieldDesc
167170
fieldDescAvailableSince v d = d { fdAvailableSince = Just v }
168171

169-
fieldDescRemovedIn :: CabalSpecVersion -> FieldDesc -> FieldDesc
170-
fieldDescRemovedIn v d = d { fdRemovedIn = Just v }
172+
fieldDescRemovedIn :: CabalSpecVersion -> String -> FieldDesc -> FieldDesc
173+
fieldDescRemovedIn v desc d = d { fdRemovedIn = Just (v, desc) }
171174

172-
fieldDescDeprecatedSince :: CabalSpecVersion -> FieldDesc -> FieldDesc
173-
fieldDescDeprecatedSince v d = d { fdDeprecatedSince = Just v }
175+
fieldDescDeprecatedSince :: CabalSpecVersion -> String -> FieldDesc -> FieldDesc
176+
fieldDescDeprecatedSince v desc d = d { fdDeprecatedSince = Just (v, desc) }
174177

175178
data FieldDesc = FieldDesc
176179
{ fdAvailableSince :: Maybe CabalSpecVersion
177-
, fdRemovedIn :: Maybe CabalSpecVersion
178-
, fdDeprecatedSince :: Maybe CabalSpecVersion
180+
, fdRemovedIn :: Maybe (CabalSpecVersion, String)
181+
, fdDeprecatedSince :: Maybe (CabalSpecVersion, String)
179182
, fdDescription :: FieldDesc'
180183
}
181184
deriving Show
@@ -227,8 +230,8 @@ instance FieldGrammar Reference where
227230
-- hidden fields are hidden from the reference.
228231
hiddenField _ = Reference Map.empty
229232

230-
deprecatedSince v _ r = referenceDeprecatedSince v r
231-
removedIn v _ r = referenceRemovedIn v r
233+
deprecatedSince = referenceDeprecatedSince
234+
removedIn = referenceRemovedIn
232235
availableSince v _ r = referenceAvailableSince v r
233236

234237
-------------------------------------------------------------------------------

0 commit comments

Comments
 (0)