Skip to content

Commit 1cace0b

Browse files
authored
Merge pull request #8276 from haskell/mergify/bp/3.8/pr-8205
Drop >= in suggestions to cabal-version (rebase #7104) (backport #8205)
2 parents 1d10444 + c9d99ee commit 1cace0b

File tree

1 file changed

+8
-8
lines changed
  • Cabal/src/Distribution/PackageDescription

1 file changed

+8
-8
lines changed

Cabal/src/Distribution/PackageDescription/Check.hs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ checkExecutable pkg exe =
299299
&& takeExtension (modulePath exe) `notElem` [".hs", ".lhs"]) $
300300
PackageDistInexcusable $
301301
"The package uses a C/C++/obj-C source file for the 'main-is' field. "
302-
++ "To use this feature you must specify 'cabal-version: >= 1.18'."
302+
++ "To use this feature you need to specify 'cabal-version: 1.18' or higher."
303303

304304
-- check that all autogen-modules appear on other-modules
305305
, check
@@ -343,7 +343,7 @@ checkTestSuite pkg test =
343343
, checkSpecVersion pkg CabalSpecV1_18 (mainIsNotHsExt && not mainIsWrongExt) $
344344
PackageDistInexcusable $
345345
"The package uses a C/C++/obj-C source file for the 'main-is' field. "
346-
++ "To use this feature you must specify 'cabal-version: >= 1.18'."
346+
++ "To use this feature you need to specify 'cabal-version: 1.18' or higher."
347347

348348
-- check that all autogen-modules appear on other-modules
349349
, check
@@ -1186,7 +1186,7 @@ checkCabalVersion pkg =
11861186
(not . null $ extraDocFiles pkg) $
11871187
PackageDistInexcusable $
11881188
"To use the 'extra-doc-files' field the package needs to specify "
1189-
++ "at least 'cabal-version: >= 1.18'."
1189+
++ "'cabal-version: 1.18' or higher."
11901190

11911191
, checkVersion CabalSpecV2_0
11921192
(not (null (subLibraries pkg))) $
@@ -1199,7 +1199,7 @@ checkCabalVersion pkg =
11991199
(any (not.null.reexportedModules) (allLibraries pkg)) $
12001200
PackageDistInexcusable $
12011201
"To use the 'reexported-module' field the package needs to specify "
1202-
++ "at least 'cabal-version: >= 1.22'."
1202+
++ "'cabal-version: 1.22' or higher."
12031203

12041204
-- check use of thinning and renaming
12051205
, checkVersion CabalSpecV2_0 usesBackpackIncludes $
@@ -1212,7 +1212,7 @@ checkCabalVersion pkg =
12121212
-- Just a warning, because this won't break on old Cabal versions.
12131213
PackageDistSuspiciousWarn $
12141214
"To use the 'extra-framework-dirs' field the package needs to specify"
1215-
++ " at least 'cabal-version: >= 1.24'."
1215+
++ " 'cabal-version: 1.24' or higher."
12161216

12171217
-- check use of default-extensions field
12181218
-- don't need to do the equivalent check for other-extensions
@@ -1286,7 +1286,7 @@ checkCabalVersion pkg =
12861286
&& isNothing (setupBuildInfo pkg)
12871287
&& buildType pkg == Custom) $
12881288
PackageBuildWarning $
1289-
"Packages using 'cabal-version: >= 1.24' with 'build-type: Custom' "
1289+
"Packages using 'cabal-version: 1.24' or higher with 'build-type: Custom' "
12901290
++ "must use a 'custom-setup' section with a 'setup-depends' field "
12911291
++ "that specifies the dependencies of the Setup.hs script itself. "
12921292
++ "The 'setup-depends' field uses the same syntax as 'build-depends', "
@@ -1297,8 +1297,8 @@ checkCabalVersion pkg =
12971297
&& buildType pkg == Custom) $
12981298
PackageDistSuspiciousWarn $
12991299
"From version 1.24 cabal supports specifying explicit dependencies "
1300-
++ "for Custom setup scripts. Consider using cabal-version >= 1.24 and "
1301-
++ "adding a 'custom-setup' section with a 'setup-depends' field "
1300+
++ "for Custom setup scripts. Consider using 'cabal-version: 1.24' or higher "
1301+
++ "and adding a 'custom-setup' section with a 'setup-depends' field "
13021302
++ "that specifies the dependencies of the Setup.hs script itself. "
13031303
++ "The 'setup-depends' field uses the same syntax as 'build-depends', "
13041304
++ "so a simple example would be 'setup-depends: base, Cabal'."

0 commit comments

Comments
 (0)