Skip to content

Strict.alterFEager: Fix strictness #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 23, 2022

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Mar 20, 2022

Fixes #383.

@sjakobi
Copy link
Member Author

sjakobi commented Mar 20, 2022

I'm surprised that the issue383 regression test fails with GHC 8.6.5, 8.8.4, 8.10.7 and 9.2.1, while it's fixed with 9.0.2 and 9.2.2.

@sjakobi
Copy link
Member Author

sjakobi commented Mar 20, 2022

Actually I get some spurious failures now with GHC 9.2.2.

EDIT: …same with 8.10.7 and 8.6.5.

@sjakobi
Copy link
Member Author

sjakobi commented Mar 20, 2022

I have opened input-output-hk/nothunks#15 for help with this issue.

@sjakobi sjakobi force-pushed the sjakobi/383-alterFEager-strictness branch 2 times, most recently from fa117c1 to a6969f8 Compare March 21, 2022 19:00
@sjakobi sjakobi force-pushed the sjakobi/383-alterFEager-strictness branch from a6969f8 to 25c4092 Compare March 23, 2022 11:13
@sjakobi sjakobi marked this pull request as ready for review March 23, 2022 11:22
@sjakobi sjakobi merged commit f721b9d into master Mar 23, 2022
@sjakobi sjakobi deleted the sjakobi/383-alterFEager-strictness branch March 23, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict.alterFEager too lazy when inserting new key
1 participant