Fix 'compose' since tag #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, there are both "Since 0.2.10.0" and "Since 0.2.11". I'm not sure which version number style is preferred... I went with the more precise 0.2.13.0 here. |
sjakobi
approved these changes
Jan 22, 2021
|
The versioning policy doesn't allow new functions in sub-minor releases,
does it? So I think three-part versions probably make more sense there.
…On Fri, Jan 22, 2021, 11:25 AM Simon Jakobi ***@***.***> wrote:
***@***.**** approved this pull request.
Thank you! I usually update the @since-annotations while preparing a
release. Must have forgotten about that with the last release.
I don't have a clear preference regarding the version style right now.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#303 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOOF7MGCEK7CBTIDXSPIWDS3GRG3ANCNFSM4WOWKLQA>
.
|
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Hackage there is an ugly
@since UNRELEASEDin the documentation for compose. I guess #299 didn't fix the tag when it got merged.