Enrich errors caused by context cancellation #91
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the following
context.*
errors would be returned when the Terraform execution can't start because the context passed was already cancelled.This is being replaced with more informative custom
ExitError
, e.g.The following
exec.ExitError
error would be returned when execution is interrupted due to context (cancellation or deadline):which is being replaced with
ExitError
tooImportantly the
ExitError
implementsUnwrap
to remain comparable with the original context errors orexec.ExitError
, as demonstrated in attached tests.We can make deadline errors even more informative by making timeout a first-class concept and implementing custom
context.Context
which reflects that. Once that is done, the error handling here should in theory just pick it up - only tests may need to be updated. I'll raise a separate PR for this though.