Check if multierror is nil in WrappedErrors #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check similar to `ErrorsOrNil` that ensures the multierror pointer is not nil before returning the Errors field. I believe this is fully backwards-compatible, because the former behavior is a runtime panic.
|
|
|
This looks good to me. |
This was referenced Mar 11, 2021
Bump github.com/hashicorp/go-multierror from 1.1.0 to 1.1.1
hashicorp/terraform-provider-hcs#62
Closed
Bump github.com/hashicorp/go-multierror from 1.1.0 to 1.1.1
kuritka/service-discovery-simple#11
Merged
Merged
Bump github.com/hashicorp/go-multierror from 1.1.0 to 1.1.1
korenyoni/terraform-provider-aws#46
Open
build(deps): bump github.com/hashicorp/go-multierror from 1.1.0 to 1.1.1
containers/storage#854
Merged
This was referenced Mar 12, 2021
Open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check similar to
ErrorsOrNilthat ensures the multierror pointer is not nil before returning the Errors field. I believe this is fully backwards-compatible, because the former behavior is a runtime panic.