Optimise build_stubbed

Author: IgorArkhipov

spec/models/article_spec.rb

@@ -314,7 +314,7 @@ def build_and_validate_article(*args)
   end
 
   it "removes from search index" do
-    article = create(:article)
+    article = build_stubbed(:article)
     article.remove_algolia_index
   end
 
@@ -351,9 +351,7 @@ def build_and_validate_article(*args)
   end
 
   describe "::filter_excluded_tags" do
-    before do
-      create(:article, tags: "hiring")
-    end
+    let_it_be(:article) { create(:article, tags: "hiring") }
 
     it "exlude #hiring when no argument is given" do
       expect(described_class.filter_excluded_tags.length).to be(0)
@@ -379,7 +377,7 @@ def build_and_validate_article(*args)
       expect(article.path).to eq("/#{article.username}/#{article.slug}")
     end
     it "assigns cached_user_name on save" do
-      article = create(:article, user_id: user.id)
+      article = build_stubbed(:article, user_id: user.id)
       expect(article.cached_user_name).to eq(article.cached_user_name)
     end
     it "assigns cached_user_username on save" do

spec/models/notification_spec.rb

@@ -3,8 +3,8 @@
 RSpec.describe Notification, type: :model do
   let(:user)            { create(:user) }
   let(:user2)           { create(:user) }
-  let(:user3)           { create(:user) }
-  let(:organization)    { create(:organization) }
+  let_it_be(:user3)           { create(:user) }
+  let_it_be(:organization)    { create(:organization) }
   let(:article)         { create(:article, user_id: user.id, page_views_count: 4000, positive_reactions_count: 70) }
   let(:follow_instance) { user.follow(user2) }
 
@@ -86,19 +86,19 @@
       end
 
       it "does not send a notification to the author of the article if the commenter is the author" do
-        comment = create(:comment, user: user, commentable: article)
+        comment = build_stubbed(:comment, user: user, commentable: article)
         Notification.send_new_comment_notifications_without_delay(comment)
         expect(user.notifications.count).to eq 0
       end
 
       it "does not send a notification to the author of the comment" do
-        comment = create(:comment, user: user2, commentable: article)
+        comment = build_stubbed(:comment, user: user2, commentable: article)
         Notification.send_new_comment_notifications_without_delay(comment)
         expect(user2.notifications.count).to eq 0
       end
 
       it "sends a notification to the organization" do
-        org = create(:organization)
+        org = build_stubbed(:organization)
         user.update(organization: org)
         article.update(organization: org)
         comment = create(:comment, user: user2, commentable: article)
@@ -110,7 +110,7 @@
     context "when the author of the article is not subscribed" do
       it "does not send a notification to the author of the article" do
         article.update(receive_notifications: false)
-        comment = create(:comment, user: user2, commentable: article)
+        comment = build_stubbed(:comment, user: user2, commentable: article)
         Notification.send_new_comment_notifications_without_delay(comment)
         expect(user.notifications.count).to eq 0
       end
@@ -120,7 +120,7 @@
       it "does not send a notification to the author of the comment" do
         parent_comment = create(:comment, user: user2, commentable: article)
         parent_comment.update(receive_notifications: false)
-        child_comment = create(:comment, user: user, commentable: article, ancestry: parent_comment.id.to_s)
+        child_comment = build_stubbed(:comment, user: user, commentable: article, ancestry: parent_comment.id.to_s)
         Notification.send_new_comment_notifications_without_delay(child_comment)
         expect(user2.notifications.count).to eq 0
       end
@@ -147,14 +147,14 @@
       it "does not send a notification to the author of a comment" do
         comment = create(:comment, user: user2, commentable: article)
         comment.update(receive_notifications: false)
-        reaction = create(:reaction, reactable: comment, user: user)
+        reaction = build_stubbed(:reaction, reactable: comment, user: user)
         Notification.send_reaction_notification_without_delay(reaction, reaction.reactable.user)
         expect(user2.notifications.count).to eq 0
       end
 
       it "does not send a notification to the author of an article" do
         article.update(receive_notifications: false)
-        reaction = create(:reaction, reactable: article, user: user2)
+        reaction = build_stubbed(:reaction, reactable: article, user: user2)
         Notification.send_reaction_notification_without_delay(reaction, reaction.reactable.user)
         expect(user.notifications.count).to eq 0
       end