BUG/MINOR: wrong config state file path in external mode

Author: ivanmatmati

pkg/haproxy/env/main.go

@@ -101,8 +101,7 @@ func (env *Env) Init(osArgs utils.OSArgs) (err error) {
 			return err
 		}
 	}
-	_, err = os.Create(filepath.Join(env.StateDir, "global"))
-	return err
+	return
 }
 
 // When controller is not running on a containerized
@@ -112,7 +111,7 @@ func (env *Env) external(osArgs utils.OSArgs) (err error) {
 	env.MainCFGFile = "/tmp/haproxy-ingress/etc/haproxy.cfg"
 	env.CfgDir = "/tmp/haproxy-ingress/etc"
 	env.RuntimeDir = "/tmp/haproxy-ingress/run"
-	env.StateDir = "/tmp/haproxy-ingress/state"
+	env.StateDir = "/tmp/haproxy-ingress/state/"
 	if osArgs.Program != "" {
 		env.Binary = osArgs.Program
 	}

pkg/haproxy/process/interface.go

@@ -3,6 +3,7 @@ package process
 import (
 	"bufio"
 	"os"
+	"path/filepath"
 	"strconv"
 	"syscall"
 
@@ -69,7 +70,7 @@ func saveServerState(stateDir string, api runtime.Raw) error {
 		return err
 	}
 	var f *os.File
-	if f, err = os.Create(stateDir + "global"); err != nil {
+	if f, err = os.Create(filepath.Join(stateDir, "global")); err != nil {
 		logger.Error(err)
 		return err
 	}